From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUQ2Q-000104-1j for qemu-devel@nongnu.org; Wed, 08 Jun 2011 17:11:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QUQ2O-0003WC-BO for qemu-devel@nongnu.org; Wed, 08 Jun 2011 17:11:41 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:55357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUQ2N-0003Vg-Qq for qemu-devel@nongnu.org; Wed, 08 Jun 2011 17:11:40 -0400 Message-ID: <4DEFE589.2090009@web.de> Date: Wed, 08 Jun 2011 23:11:37 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <219d3206ad6eafed76d4f108a40912fe72884e19.1307550106.git.jan.kiszka@siemens.com> <20110608195316.GD30805@redhat.com> <4DEFE00A.5050005@web.de> <20110608210005.GB32260@redhat.com> <4DEFE374.7010009@web.de> <20110608210919.GD32260@redhat.com> In-Reply-To: <20110608210919.GD32260@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig42306DD4630EC6640257C9B1" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig42306DD4630EC6640257C9B1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-06-08 23:09, Michael S. Tsirkin wrote: > On Wed, Jun 08, 2011 at 11:02:44PM +0200, Jan Kiszka wrote: >> On 2011-06-08 23:00, Michael S. Tsirkin wrote: >>> On Wed, Jun 08, 2011 at 10:48:10PM +0200, Jan Kiszka wrote: >>>> On 2011-06-08 21:53, Michael S. Tsirkin wrote: >>>>> On Wed, Jun 08, 2011 at 06:21:51PM +0200, Jan Kiszka wrote: >>>>>> Add PCI_MSIX_TABLE and PCI_MSIX_PBA, align other MSIX related cons= tant >>>>>> names to libpci style. Will be used for device assignment code in >>>>>> qemu-kvm. >>>>>> >>>>>> Signed-off-by: Jan Kiszka >>>>> >>>>> Besides keeping pci_regs.h aligned with the original, >>>>> I also think ideally pci register banging should stay >>>>> within the pci subsystem. >>>>> >>>>> Could we add high-level APIs to help with that, >>>>> instead of having kvm look at config space directly? >>>> >>>> We could move the related static inlines from msi/msix.c to the head= ers >>>> in order to test for bits etc. Still, kvm needs to interpret the con= fig >>>> space of the assigned device, so the abstraction will remain rather = low. >>>> >>>> Jan >>>> >>> >>> Hmm, at least for MSI/MSIX I thought this is done by kvm in kernel? >>> >> >> At least for the "traditional" assignment interface (VFIO may offload >> something), no. User space does the cap analysis, filtering, and in th= e >> MSI/MSI-X case the translation to QEMU msi/msix services. The latter i= s >> even WIP in my tree. Surrent assignment open-codes this, missing many >> corner cases. >> >> Jan >> >=20 > Anyway, if some defines need to be in a header, and aren't upstream > yet, let's create pci_ext_regs.h and add a comment there that we > should work on upstreaming them. Sounds good. But what is supposed to be upstream for us, the kernel or pci-utils/libpci? Jan --------------enig42306DD4630EC6640257C9B1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk3v5YkACgkQitSsb3rl5xTCjgCgjXbM8/dT/OQ1EvtIySuC6EBG ROgAnjSziByNJ+e8TqlzONMPdN5ye28b =4AvM -----END PGP SIGNATURE----- --------------enig42306DD4630EC6640257C9B1--