From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUQEa-0004AW-2j for qemu-devel@nongnu.org; Wed, 08 Jun 2011 17:24:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QUQEX-0005d1-GA for qemu-devel@nongnu.org; Wed, 08 Jun 2011 17:24:15 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:38634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUQEW-0005cZ-Qm for qemu-devel@nongnu.org; Wed, 08 Jun 2011 17:24:13 -0400 Message-ID: <4DEFE87A.3000608@web.de> Date: Wed, 08 Jun 2011 23:24:10 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20110608194845.GC30805@redhat.com> <4DEFDF4A.1010501@web.de> <20110608205622.GA32260@redhat.com> <4DEFE229.4030000@web.de> <20110608210148.GC32260@redhat.com> <4DEFE3AF.50302@web.de> <20110608211457.GE32260@redhat.com> <4DEFE70D.90300@web.de> In-Reply-To: <4DEFE70D.90300@web.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig54A696DCD489572408D1EE1D" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH v2 9/9] msi: Move PCI_MSI_PENDING_32/64 into pci_regs.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig54A696DCD489572408D1EE1D Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-06-08 23:18, Jan Kiszka wrote: > On 2011-06-08 23:14, Michael S. Tsirkin wrote: >> On Wed, Jun 08, 2011 at 11:03:43PM +0200, Jan Kiszka wrote: >>> On 2011-06-08 23:01, Michael S. Tsirkin wrote: >>>> On Wed, Jun 08, 2011 at 10:57:13PM +0200, Jan Kiszka wrote: >>>>> On 2011-06-08 22:56, Michael S. Tsirkin wrote: >>>>>> On Wed, Jun 08, 2011 at 10:44:58PM +0200, Jan Kiszka wrote: >>>>>>> On 2011-06-08 21:48, Michael S. Tsirkin wrote: >>>>>>>> On Wed, Jun 08, 2011 at 06:21:52PM +0200, Jan Kiszka wrote: >>>>>>>>> Signed-off-by: Jan Kiszka >>>>>>>> >>>>>>>> pci_regs.h from linux does not have these >>>>>>>> this is why we keep them in msi.c >>>>>>>> >>>>>>>> [mst@tuck linux-2.6]$ grep PCI_MSI_ include/linux/pci_regs.h=20 >>>>>>>> #define PCI_MSI_FLAGS 2 /* Various flags */ >>>>>>>> #define PCI_MSI_FLAGS_64BIT 0x80 /* 64-bit addresses allo= wed */ >>>>>>>> #define PCI_MSI_FLAGS_QSIZE 0x70 /* Message queue size co= nfigured >>>>>>>> */ >>>>>>>> #define PCI_MSI_FLAGS_QMASK 0x0e /* Maximum queue size av= ailable >>>>>>>> */ >>>>>>>> #define PCI_MSI_FLAGS_ENABLE 0x01 /* MSI feature enabled *= / >>>>>>>> #define PCI_MSI_FLAGS_MASKBIT 0x100 /* 64-bit mask bits allo= wed */ >>>>>>>> #define PCI_MSI_RFU 3 /* Rest of capability fl= ags */ >>>>>>>> #define PCI_MSI_ADDRESS_LO 4 /* Lower 32 bits */ >>>>>>>> #define PCI_MSI_ADDRESS_HI 8 /* Upper 32 bits (if >>>>>>>> PCI_MSI_FLAGS_64BIT set) */ >>>>>>>> #define PCI_MSI_DATA_32 8 /* 16 bits of data for 3= 2-bit >>>>>>>> devices */ >>>>>>>> #define PCI_MSI_MASK_32 12 /* Mask bits register fo= r 32-bit >>>>>>>> devices */ >>>>>>>> #define PCI_MSI_DATA_64 12 /* 16 bits of data for 6= 4-bit >>>>>>>> devices */ >>>>>>>> #define PCI_MSI_MASK_64 16 /* Mask bits register fo= r 64-bit >>>>>>>> devices */ >>>>>>>> >>>>>>>> >>>>>>>> If you want to move them, please send them upstream we'll merge = when >>>>>>>> they are there. >>>>>>> >>>>>>> In fact, both defines are already in libpci. Since 3.0.0. Release= d 5 >>>>>>> years ago. OK, I'll send a header resync patch against a more rec= ent >>>>>>> release. >>>>>>> >>>>>>> Then we should just lack something like PCI_MSIX_CTRL. I will hav= e a look. >>>>>> >>>>>> PCI_MSIX_FLAGS is the same. >>>>> >>>>> That does not exist in libpci's header. >>>>> >>>>> Jan >>>>> >>>> >>>> The upstream I meant is pci_Regs.h in Linux. >>>> >>> >>> Why not sync against >>> git://git.kernel.org/pub/scm/utils/pciutils/pciutils.git? Sounds more= >>> appropriate. >>> >>> Jan >>> >> >> We are 100% aligned with Linux changing that seems pointless. >> I think Linux gets new hardware features faster and has a better >> chance to be correct. >> We already pull headers from Linux so that's one dependency less. >> >=20 > The kernel appears to gain defines based on what it uses. The libpci > headers seem to serve more use cases, at least it had the missing field= s > for several years and is a few hundred lines longer. OK, looks like that "added value" comes from merging pci_regs.h with pci_ids.h. Never mind, will work against the kernel. Jan --------------enig54A696DCD489572408D1EE1D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk3v6HsACgkQitSsb3rl5xRWvQCfdH/vzPz9PCCETrA1c9ICTH0m 6YUAoIbYvN47haFHWnOLFmtL5SFCrqJl =Z+AA -----END PGP SIGNATURE----- --------------enig54A696DCD489572408D1EE1D--