From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: aliguori@us.ibm.com, quintela@redhat.com,
Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] savevm: fix corruption in vmstate_subsection_load().
Date: Thu, 09 Jun 2011 15:19:35 +0200 [thread overview]
Message-ID: <4DF0C867.2030502@redhat.com> (raw)
In-Reply-To: <4DF0C100.2040200@redhat.com>
On 06/09/2011 02:48 PM, Kevin Wolf wrote:
> This means that subsections are silently ignored if the old version
> didn't have any subsection for the device. Wasn't it a fundamental point
> of the design of subsections that this would fail?
Unfortunately you cannot have it both ways because the migration format
is ambiguous.
> Noticed this when trying to use subsections to fix up IDE, and new ->
> old migration after an I/O error only correctly fails when I revert this
> patch.
I would have expected migration to fail anyway because the next
instances are not parsed correctly.
Paolo
prev parent reply other threads:[~2011-06-09 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 9:30 [Qemu-devel] [PATCH v2] savevm: fix corruption in vmstate_subsection_load() Yoshiaki Tamura
2011-01-24 15:35 ` [Qemu-devel] " Paolo Bonzini
2011-06-09 12:48 ` [Qemu-devel] " Kevin Wolf
2011-06-09 13:19 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF0C867.2030502@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=tamura.yoshiaki@lab.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).