From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUf9O-0004y9-32 for qemu-devel@nongnu.org; Thu, 09 Jun 2011 09:19:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QUf9M-0002zf-09 for qemu-devel@nongnu.org; Thu, 09 Jun 2011 09:19:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUf9L-0002zZ-DW for qemu-devel@nongnu.org; Thu, 09 Jun 2011 09:19:51 -0400 Message-ID: <4DF0C867.2030502@redhat.com> Date: Thu, 09 Jun 2011 15:19:35 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1295861427-30851-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <4DF0C100.2040200@redhat.com> In-Reply-To: <4DF0C100.2040200@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] savevm: fix corruption in vmstate_subsection_load(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: aliguori@us.ibm.com, quintela@redhat.com, Yoshiaki Tamura , qemu-devel@nongnu.org On 06/09/2011 02:48 PM, Kevin Wolf wrote: > This means that subsections are silently ignored if the old version > didn't have any subsection for the device. Wasn't it a fundamental point > of the design of subsections that this would fail? Unfortunately you cannot have it both ways because the migration format is ambiguous. > Noticed this when trying to use subsections to fix up IDE, and new -> > old migration after an I/O error only correctly fails when I revert this > patch. I would have expected migration to fail anyway because the next instances are not parsed correctly. Paolo