Re: [Qemu-devel] [PATCH v2][ 05/21] qapi: add qapi-types.py code generator

[Michael Roth <mdroth@linux.vnet.ibm.com>]

On 06/09/2011 10:05 AM, Luiz Capitulino wrote:
> On Fri,  3 Jun 2011 17:33:03 -0500
> Michael Roth<mdroth@linux.vnet.ibm.com>  wrote:
>
>> This is the code generator for qapi types. It will generation the
>> following files:
>>
>>    $(prefix)qapi-types.h - C types corresponding to types defined in
>>                            the schema you pass in
>>    $(prefix)qapi-types.c - Cleanup functions for the above C types
>>
>> The $(prefix) is used to as a namespace to keep the generated code from
>> one schema/code-generation separated from others so code and be
>> generated from multiple schemas with clobbering previously created code.
>
> This is generating code that can't be built, because the qapi modules are
> being added after the code generator. I think we should do the opposite:
> the qapi modules have to be introduced before anything which uses them.

Makes sense.

>
> Also note that a patch adding a module should also update the Makefile, so
> that the module can be built.

Ok, I'll try to do this for the re-spin.