From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36403)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1QUh9i-0008Ew-8o
	for qemu-devel@nongnu.org; Thu, 09 Jun 2011 11:28:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1QUh9g-0001ui-An
	for qemu-devel@nongnu.org; Thu, 09 Jun 2011 11:28:22 -0400
Received: from e6.ny.us.ibm.com ([32.97.182.146]:40718)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1QUh9f-0001uV-Ti
	for qemu-devel@nongnu.org; Thu, 09 Jun 2011 11:28:20 -0400
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e6.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p59F49mc016659
	for <qemu-devel@nongnu.org>; Thu, 9 Jun 2011 11:04:09 -0400
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p59FSIkX095880
	for <qemu-devel@nongnu.org>; Thu, 9 Jun 2011 11:28:18 -0400
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p59FSH6W014822
	for <qemu-devel@nongnu.org>; Thu, 9 Jun 2011 11:28:18 -0400
Message-ID: <4DF0E690.5000209@linux.vnet.ibm.com>
Date: Thu, 09 Jun 2011 10:28:16 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1307140399-9023-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1307140399-9023-6-git-send-email-mdroth@linux.vnet.ibm.com>
	<20110609120523.53261d57@doriath>
In-Reply-To: <20110609120523.53261d57@doriath>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2][ 05/21] qapi: add qapi-types.py code
	generator
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@linux.vnet.ibm.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org, Jes.Sorensen@redhat.com

On 06/09/2011 10:05 AM, Luiz Capitulino wrote:
> On Fri,  3 Jun 2011 17:33:03 -0500
> Michael Roth<mdroth@linux.vnet.ibm.com>  wrote:
>
>> This is the code generator for qapi types. It will generation the
>> following files:
>>
>>    $(prefix)qapi-types.h - C types corresponding to types defined in
>>                            the schema you pass in
>>    $(prefix)qapi-types.c - Cleanup functions for the above C types
>>
>> The $(prefix) is used to as a namespace to keep the generated code from
>> one schema/code-generation separated from others so code and be
>> generated from multiple schemas with clobbering previously created code.
>
> This is generating code that can't be built, because the qapi modules are
> being added after the code generator. I think we should do the opposite:
> the qapi modules have to be introduced before anything which uses them.

Makes sense.

>
> Also note that a patch adding a module should also update the Makefile, so
> that the module can be built.

Ok, I'll try to do this for the re-spin.