From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUqaA-0004y1-D4 for qemu-devel@nongnu.org; Thu, 09 Jun 2011 21:32:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QUqa8-0001qR-Jd for qemu-devel@nongnu.org; Thu, 09 Jun 2011 21:32:18 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:50959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUqa8-0001po-BE for qemu-devel@nongnu.org; Thu, 09 Jun 2011 21:32:16 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e34.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p5A1JUXn021422 for ; Thu, 9 Jun 2011 19:19:30 -0600 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id p5A1WE5H147374 for ; Thu, 9 Jun 2011 19:32:14 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5A1WE7s028317 for ; Thu, 9 Jun 2011 19:32:14 -0600 Received: from oc6675851006.ibm.com (sig-9-65-39-156.mts.ibm.com [9.65.39.156]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p5A1WEHd028295 for ; Thu, 9 Jun 2011 19:32:14 -0600 Message-ID: <4DF1741D.1000009@linux.vnet.ibm.com> Date: Thu, 09 Jun 2011 18:32:13 -0700 From: Venkateswararao Jujjuri MIME-Version: 1.0 References: <1307380618-1963-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1307380618-1963-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com> In-Reply-To: <1307380618-1963-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] hw/9pfs: Use v9fs_do_close instead of close List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 06/06/2011 10:16 AM, Aneesh Kumar K.V wrote: > we should use the local abstraction instead of > directly calling close. > Let us fold this also into our coroutine patches. - JV > Signed-off-by: Aneesh Kumar K.V > --- > hw/9pfs/virtio-9p.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c > index 21e07fb..d322814 100644 > --- a/hw/9pfs/virtio-9p.c > +++ b/hw/9pfs/virtio-9p.c > @@ -1596,7 +1596,7 @@ static void v9fs_lcreate(void *opaque) > if (err< 0) { > fidp->fid_type = P9_FID_NONE; > if (fidp->fs.fd> 0) { > - close(fidp->fs.fd); > + v9fs_co_close(pdu->s, fidp->fs.fd); > } > goto out; > } > @@ -2164,7 +2164,7 @@ static void v9fs_create(void *opaque) > if (err< 0) { > fidp->fid_type = P9_FID_NONE; > if (fidp->fs.fd) { > - close(fidp->fs.fd); > + v9fs_co_close(pdu->s, fidp->fs.fd); > } > goto out; > }