From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49553)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QV42b-0002vY-2r
	for qemu-devel@nongnu.org; Fri, 10 Jun 2011 11:54:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QV42Z-0006dv-Pm
	for qemu-devel@nongnu.org; Fri, 10 Jun 2011 11:54:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:18926)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QV42Z-0006dp-9Y
	for qemu-devel@nongnu.org; Fri, 10 Jun 2011 11:54:31 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5AFsTBj030607
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 10 Jun 2011 11:54:29 -0400
Message-ID: <4DF23EE1.60500@redhat.com>
Date: Fri, 10 Jun 2011 17:57:21 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1307456313-9884-1-git-send-email-kwolf@redhat.com>
	<20110610123243.0b12b24c@doriath>
In-Reply-To: <20110610123243.0b12b24c@doriath>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/3] block: Avoid direct AIO callback
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org

Am 10.06.2011 17:32, schrieb Luiz Capitulino:
> On Tue,  7 Jun 2011 16:18:30 +0200
> Kevin Wolf <kwolf@redhat.com> wrote:
> 
>> This series fixes some cases of block drivers calling AIO callbacks too early.
>> It fixes the IDE assertion failure reported by Luiz (in error cases, the DMA
>> status, including acb, could first be reset in the callback and only then be
>> set by the caller, resulting in a dangling acb and wrong status register value).
> 
> This fixes the reported bug, thanks.
> 
> I know this is a different subject, but I'm still unable to use the host cdrom
> if the -snapshot flag is passed, I think the idea of ignoring the flag for a
> read-only device would fix this, no?

Yes, it would. But as we discussed it would have other implications that
I wouldn't feel comfortable about (surprising semantics of 'commit'
would be one).

Passing things like bdrv_eject() or bdrv_is_inserted() to the backing
file still sounds like a cleaner approach, but probably isn't as easy.

Kevin