qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Luiz Capitulino <lcapitulino@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] Reset system before loadvm
Date: Sat, 11 Jun 2011 11:05:10 +0200	[thread overview]
Message-ID: <4DF32FC6.3040607@web.de> (raw)

From: Jan Kiszka <jan.kiszka@siemens.com>

In case we load the vmstate during incoming migration, we start from a
clean, default machine state as we went through system reset before. But
if we load from a snapshot, the machine can be in any state. That can
cause troubles if loading an older image which does not carry all state
information the executing QEMU requires. Almost no device takes care of
this scenario.

However, fixing this is trivial. We just need to issue a system reset
during loadvm as well.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 savevm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/savevm.c b/savevm.c
index 98b2422..5db01aa 100644
--- a/savevm.c
+++ b/savevm.c
@@ -2074,6 +2074,7 @@ int load_vmstate(const char *name)
         return -EINVAL;
     }
 
+    qemu_system_reset();
     ret = qemu_loadvm_state(f);
 
     qemu_fclose(f);
-- 
1.7.1

             reply	other threads:[~2011-06-11  9:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-11  9:05 Jan Kiszka [this message]
2011-06-12 17:13 ` [Qemu-devel] [PATCH] Reset system before loadvm Avi Kivity
2011-06-14  6:19   ` Jan Kiszka
2011-06-14 10:50     ` Avi Kivity
2011-06-14 10:56       ` Jan Kiszka
2011-06-14 11:14         ` Avi Kivity
2011-06-14 15:45           ` Luiz Capitulino
2011-06-12 17:42 ` Peter Maydell
2011-06-14  6:16   ` Jan Kiszka
2011-06-14 16:29 ` [Qemu-devel] [PATCH 1/2] Allow silent system resets Jan Kiszka
2011-06-15 14:32   ` Luiz Capitulino
2011-06-14 16:29 ` [Qemu-devel] [PATCH v2 2/2] Reset system before loadvm Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF32FC6.3040607@web.de \
    --to=jan.kiszka@web.de \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).