From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47158)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1QWMvf-0004GB-QD
	for qemu-devel@nongnu.org; Tue, 14 Jun 2011 02:16:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1QWMve-00073t-DU
	for qemu-devel@nongnu.org; Tue, 14 Jun 2011 02:16:47 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:38002)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1QWMvd-00073m-UX
	for qemu-devel@nongnu.org; Tue, 14 Jun 2011 02:16:46 -0400
Message-ID: <4DF6FCCC.3030803@web.de>
Date: Tue, 14 Jun 2011 08:16:44 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4DF32FC6.3040607@web.de>
	<BANLkTinbeXYnDXoTueY9G4gSzF7LB8i8Nw@mail.gmail.com>
In-Reply-To: <BANLkTinbeXYnDXoTueY9G4gSzF7LB8i8Nw@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigBA6A4136A3253EF60E64A805"
Sender: jan.kiszka@web.de
Subject: Re: [Qemu-devel] [PATCH] Reset system before loadvm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigBA6A4136A3253EF60E64A805
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 2011-06-12 19:42, Peter Maydell wrote:
> On 11 June 2011 10:05, Jan Kiszka <jan.kiszka@web.de> wrote:
>> @@ -2074,6 +2074,7 @@ int load_vmstate(const char *name)
>>         return -EINVAL;
>>     }
>>
>> +    qemu_system_reset();
>>     ret =3D qemu_loadvm_state(f);
>=20
> This means that if we're doing a load because the user
> passed -loadvm on the command line we'll end up doing
> qemu_system_reset() twice (once in vl.c and then again
> here). Does that matter?

I don't think it's worth optimizing. E.g. we already reset every PCI
device twice during normal reset.

Jan


--------------enigBA6A4136A3253EF60E64A805
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk32/MwACgkQitSsb3rl5xQU4wCfWeaAi0kU75h+3VAMp1r89/Yb
WvkAoMkxrLjaHIlnv40Zo1dqOZKhbut1
=sHrQ
-----END PGP SIGNATURE-----

--------------enigBA6A4136A3253EF60E64A805--