From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWY7z-0004pj-NC for qemu-devel@nongnu.org; Tue, 14 Jun 2011 14:14:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QWY7x-0005D3-QK for qemu-devel@nongnu.org; Tue, 14 Jun 2011 14:14:15 -0400 Received: from goliath.siemens.de ([192.35.17.28]:27622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWY7x-0005Cb-09 for qemu-devel@nongnu.org; Tue, 14 Jun 2011 14:14:13 -0400 Message-ID: <4DF7A4F2.9000708@siemens.com> Date: Tue, 14 Jun 2011 20:14:10 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1308073492-24789-1-git-send-email-rth@twiddle.net> In-Reply-To: <1308073492-24789-1-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vga: Fix type of map_addr/end. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel On 2011-06-14 19:44, Richard Henderson wrote: > These addresses have been passed through pci_to_cpu_addr, > and thus need to be full target_phys_addr_t. Basically correct, but you also need to change the types of lfb_addr/end, no? > > Signed-off-by: Richard Henderson > Cc: Jan Kiszka > --- > hw/vga_int.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > Jan's recent patch series reminded me that I found a related > problem in my alpha-softmmu port this past weekend. Note that > the slight re-ordering of the members avoids extra padding in > the structure due to alignment. Yeah, and I just noticed a harmless mistyping in my patches while thinking about your type changes. Jan > > > diff --git a/hw/vga_int.h b/hw/vga_int.h > index d2811bd..b65775b 100644 > --- a/hw/vga_int.h > +++ b/hw/vga_int.h > @@ -109,9 +109,9 @@ typedef struct VGACommonState { > uint32_t vram_size; > uint32_t lfb_addr; > uint32_t lfb_end; > - uint32_t map_addr; > - uint32_t map_end; > uint32_t lfb_vram_mapped; /* whether 0xa0000 is mapped as ram */ > + target_phys_addr_t map_addr; > + target_phys_addr_t map_end; > uint32_t latch; > uint8_t sr_index; > uint8_t sr[256]; -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux