From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWYYw-0003XZ-Tt for qemu-devel@nongnu.org; Tue, 14 Jun 2011 14:42:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QWYYu-0002D2-Mp for qemu-devel@nongnu.org; Tue, 14 Jun 2011 14:42:06 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:58709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWYYu-0002Cd-3b for qemu-devel@nongnu.org; Tue, 14 Jun 2011 14:42:04 -0400 Received: by yxs7 with SMTP id 7so1424015yxs.4 for ; Tue, 14 Jun 2011 11:42:03 -0700 (PDT) Sender: Richard Henderson Message-ID: <4DF7AB77.6070003@twiddle.net> Date: Tue, 14 Jun 2011 11:41:59 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1308073492-24789-1-git-send-email-rth@twiddle.net> <4DF7A4F2.9000708@siemens.com> In-Reply-To: <4DF7A4F2.9000708@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vga: Fix type of map_addr/end. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel On 06/14/2011 11:14 AM, Jan Kiszka wrote: > On 2011-06-14 19:44, Richard Henderson wrote: >> These addresses have been passed through pci_to_cpu_addr, >> and thus need to be full target_phys_addr_t. > > Basically correct, but you also need to change the types of > lfb_addr/end, no? Ah, yes, I see that path now. Will re-send. r~