From: Gerd Hoffmann <kraxel@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 01/13] spice: Use cpu_register_physical_memory_log for dirty log enabling
Date: Wed, 15 Jun 2011 08:42:07 +0200 [thread overview]
Message-ID: <4DF8543F.1030106@redhat.com> (raw)
In-Reply-To: <ef059539567cdcf0c45fb2ffa7717348be606a09.1308070416.git.jan.kiszka@siemens.com>
Hi,
> Note: The addtional vga_dirty_log_start for the primary interface looked
> stray. qxl_write_config enabled logging for all interfaces anyway.
No. qxl_write_config is hooked for the primary only.
> case QXL_RAM_RANGE_INDEX:
> - cpu_register_physical_memory(addr, size, qxl->vga.vram_offset | IO_MEM_RAM);
> + cpu_register_physical_memory_log(addr, size,
> + qxl->vga.vram_offset | IO_MEM_RAM,
> + 0, true);
if (qxl->id == 0) {
cpu_register_physical_memory_log(...)
} else {
cpu_register_physical_memory()
}
Only the primary is vga compatible and thus needs dirty logging.
cheers,
Gerd
next prev parent reply other threads:[~2011-06-15 6:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 16:53 [Qemu-devel] [PATCH 00/13] vga: dirty log cleanup, more linear mapping Jan Kiszka
2011-06-14 16:53 ` [Qemu-devel] [PATCH 01/13] spice: Use cpu_register_physical_memory_log for dirty log enabling Jan Kiszka
2011-06-15 6:42 ` Gerd Hoffmann [this message]
2011-06-15 7:23 ` [Qemu-devel] [PATCH v2 " Jan Kiszka
2011-06-15 8:50 ` Gerd Hoffmann
2011-06-14 16:53 ` [Qemu-devel] [PATCH 02/13] vga-pci: " Jan Kiszka
2011-06-14 16:53 ` [Qemu-devel] [PATCH 03/13] cirrus-vga: Drop redundant vga_dirty_log_start Jan Kiszka
2011-06-14 16:53 ` [Qemu-devel] [PATCH 04/13] vmware-vga: Disable verbose mode Jan Kiszka
2011-06-14 16:53 ` [Qemu-devel] [PATCH 05/13] vmware-vga: Remove dead DIRECT_VRAM mode Jan Kiszka
2011-06-14 16:53 ` [Qemu-devel] [PATCH 06/13] vmware-vga: Eliminate vga_dirty_log_restart Jan Kiszka
2011-06-15 23:48 ` andrzej zaborowski
2011-06-14 16:53 ` [Qemu-devel] [PATCH 07/13] vmware_vga: Do not enable dirty logging when in SVGA mode Jan Kiszka
2011-06-16 0:06 ` andrzej zaborowski
2011-06-14 16:53 ` [Qemu-devel] [PATCH 08/13] vmware-vga: Register reset service Jan Kiszka
2011-06-15 23:55 ` andrzej zaborowski
2011-06-14 16:53 ` [Qemu-devel] [PATCH 09/13] vmware-vga: Use cpu_register_physical_memory_log for dirty log enabling Jan Kiszka
2011-06-16 0:06 ` andrzej zaborowski
2011-06-14 16:53 ` [Qemu-devel] [PATCH 10/13] Drop dirty log start/stop infrastructure Jan Kiszka
2011-06-23 11:09 ` [Qemu-devel] [PATCH v2 " Jan Kiszka
2011-06-23 11:53 ` Avi Kivity
2011-06-14 16:53 ` [Qemu-devel] [PATCH 11/13] vga: Refactor lfb_vram_mapped to vga_mem_mapped Jan Kiszka
2011-06-14 16:53 ` [Qemu-devel] [PATCH 12/13] vga: Move vga_sync_dirty_bitmap Jan Kiszka
2011-06-14 16:53 ` [Qemu-devel] [PATCH 13/13] vga: Use linear mapping + dirty logging in chain 4 memory access mode Jan Kiszka
2011-06-23 11:11 ` [Qemu-devel] [PATCH 00/13] vga: dirty log cleanup, more linear mapping Avi Kivity
2011-06-23 11:39 ` Jan Kiszka
2011-06-23 11:44 ` Avi Kivity
2011-06-23 11:52 ` Jan Kiszka
2011-06-23 11:54 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF8543F.1030106@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).