From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40727)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QWjnp-0003gu-KN
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 02:42:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QWjno-0007ft-5Y
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 02:42:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59677)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QWjnn-0007fn-N8
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 02:42:11 -0400
Message-ID: <4DF8543F.1030106@redhat.com>
Date: Wed, 15 Jun 2011 08:42:07 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <cover.1308070416.git.jan.kiszka@siemens.com>
	<ef059539567cdcf0c45fb2ffa7717348be606a09.1308070416.git.jan.kiszka@siemens.com>
In-Reply-To: <ef059539567cdcf0c45fb2ffa7717348be606a09.1308070416.git.jan.kiszka@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/13] spice: Use
 cpu_register_physical_memory_log for dirty log enabling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

   Hi,

> Note: The addtional vga_dirty_log_start for the primary interface looked
> stray. qxl_write_config enabled logging for all interfaces anyway.

No.  qxl_write_config is hooked for the primary only.

>       case QXL_RAM_RANGE_INDEX:
> -        cpu_register_physical_memory(addr, size, qxl->vga.vram_offset | IO_MEM_RAM);
> +        cpu_register_physical_memory_log(addr, size,
> +                                         qxl->vga.vram_offset | IO_MEM_RAM,
> +                                         0, true);

if (qxl->id == 0) {
     cpu_register_physical_memory_log(...)
} else {
     cpu_register_physical_memory()
}

Only the primary is vga compatible and thus needs dirty logging.

cheers,
   Gerd