From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56479)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1QWlgT-0008A5-DJ
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 04:42:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1QWlgQ-0003dh-UH
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 04:42:45 -0400
Received: from goliath.siemens.de ([192.35.17.28]:20962)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1QWlgQ-0003d7-6g
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 04:42:42 -0400
Message-ID: <4DF8706E.4030302@siemens.com>
Date: Wed, 15 Jun 2011 10:42:22 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <cover.1308072799.git.mst@redhat.com>
	<b8c61957187f86291291abfaed88f44ac8d41b95.1308072799.git.mst@redhat.com>
	<4DF8617F.20700@redhat.com> <20110615082532.GA31267@redhat.com>
In-Reply-To: <20110615082532.GA31267@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/10] kvm: remove unused variables
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Alexander Graf <agraf@suse.de>, Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, Isaku Yamahata <yamahata@valinux.co.jp>, Riku Voipio <riku.voipio@iki.fi>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Christoph Hellwig <hch@lst.de>, Blue Swirl <blauwirbel@gmail.com>, Alex Williamson <alex.williamson@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, Avi Kivity <avi@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, Paul Brook <paul@codesourcery.com>

On 2011-06-15 10:25, Michael S. Tsirkin wrote:
> On Wed, Jun 15, 2011 at 09:38:39AM +0200, Kevin Wolf wrote:
>> Am 14.06.2011 19:36, schrieb Michael S. Tsirkin:
>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>> ---
>>>  hw/virtio-pci.h   |    8 +++++---
>>>  target-i386/kvm.c |    3 +--
>>>  2 files changed, 6 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/hw/virtio-pci.h b/hw/virtio-pci.h
>>> index a4b5fd3..b518917 100644
>>> --- a/hw/virtio-pci.h
>>> +++ b/hw/virtio-pci.h
>>> @@ -37,7 +37,9 @@ typedef struct {
>>>      bool ioeventfd_started;
>>>  } VirtIOPCIProxy;
>>>  
>>> -extern void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev,
>>> -                            uint16_t vendor, uint16_t device,
>>> -                            uint16_t class_code, uint8_t pif);
>>> +void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev);
>>> +
>>> +/* Virtio ABI version, if we increment this, we break the guest driver. */
>>> +#define VIRTIO_PCI_ABI_VERSION          0
>>> +
>>>  #endif
>>
>> Is this hunk there intentionally?
>>
>> Kevin
> 
> Sorry, this belongs in another patch.
> Thanks for pointing this out.
> Otherwise ack?

I've still the true fix pending, but there are concerns about the
associated savevm version increase for the CPU. Not sure what will
happen the next days till -rc0, so we may also go with any of these
removal patches (you weren't the first by far).

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux