From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWpUF-0004u2-0a for qemu-devel@nongnu.org; Wed, 15 Jun 2011 08:46:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QWpU5-0004eL-PG for qemu-devel@nongnu.org; Wed, 15 Jun 2011 08:46:22 -0400 Received: from mail.windriver.com ([147.11.1.11]:61016) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWpU4-0004at-Hx for qemu-devel@nongnu.org; Wed, 15 Jun 2011 08:46:13 -0400 Message-ID: <4DF8A940.40006@windriver.com> Date: Wed, 15 Jun 2011 07:44:48 -0500 From: Chris Krumme MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/10] kvm: remove unused variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Kevin Wolf , Anthony Liguori , Riku Voipio , Stefan Hajnoczi , kvm@vger.kernel.org, Jan Kiszka , Marcelo Tosatti , qemu-devel@nongnu.org, Alexander Graf , Blue Swirl , Isaku Yamahata , Alex Williamson , Gerd Hoffmann , Paolo Bonzini , Avi Kivity , Richard Henderson , Christoph Hellwig , Aurelien Jarno , Paul Brook On 06/14/2011 12:36 PM, Michael S. Tsirkin wrote: > Signed-off-by: Michael S. Tsirkin > --- > hw/virtio-pci.h | 8 +++++--- > target-i386/kvm.c | 3 +-- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/hw/virtio-pci.h b/hw/virtio-pci.h > index a4b5fd3..b518917 100644 > --- a/hw/virtio-pci.h > +++ b/hw/virtio-pci.h > @@ -37,7 +37,9 @@ typedef struct { > bool ioeventfd_started; > } VirtIOPCIProxy; > > -extern void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev, > - uint16_t vendor, uint16_t device, > - uint16_t class_code, uint8_t pif); > +void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev); Hello MST, The above change shows why we should be including a header, rather than having private prototypes (w/bitrot). > + > +/* Virtio ABI version, if we increment this, we break the guest driver. */ > +#define VIRTIO_PCI_ABI_VERSION 0 > + This change seems unrelated. Thanks Chris > #endif > diff --git a/target-i386/kvm.c b/target-i386/kvm.c > index faedc6c..58a70bc 100644 > --- a/target-i386/kvm.c > +++ b/target-i386/kvm.c > @@ -970,7 +970,7 @@ static int kvm_get_xsave(CPUState *env) > #ifdef KVM_CAP_XSAVE > struct kvm_xsave* xsave; > int ret, i; > - uint16_t cwd, swd, twd, fop; > + uint16_t cwd, swd, twd; > > if (!kvm_has_xsave()) { > return kvm_get_fpu(env); > @@ -986,7 +986,6 @@ static int kvm_get_xsave(CPUState *env) > cwd = (uint16_t)xsave->region[0]; > swd = (uint16_t)(xsave->region[0]>> 16); > twd = (uint16_t)xsave->region[1]; > - fop = (uint16_t)(xsave->region[1]>> 16); > env->fpstt = (swd>> 11)& 7; > env->fpus = swd; > env->fpuc = cwd;