From: Wen Congyang <wency@cn.fujitsu.com>
To: Aurelien Jarno <aurelien@aurel32.net>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] fix the return value of rtl8139_can_receive()
Date: Thu, 16 Jun 2011 16:23:56 +0800 [thread overview]
Message-ID: <4DF9BD9C.1060307@cn.fujitsu.com> (raw)
If rtl8139_can_receive() returns 1, it means that the nic can receive packet,
otherwise, it means the nic can not receive packet.
If !s->clock_enabled or !rtl8139_receiver_enabled(s), it means that the nic
can not receive packet. So the return value should be 0, not 1.
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
---
hw/rtl8139.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/rtl8139.c b/hw/rtl8139.c
index 2f8db58..9084678 100644
--- a/hw/rtl8139.c
+++ b/hw/rtl8139.c
@@ -810,9 +810,9 @@ static int rtl8139_can_receive(VLANClientState *nc)
/* Receive (drop) packets if card is disabled. */
if (!s->clock_enabled)
- return 1;
+ return 0;
if (!rtl8139_receiver_enabled(s))
- return 1;
+ return 0;
if (rtl8139_cp_receiver_enabled(s)) {
/* ??? Flow control not implemented in c+ mode.
--
1.7.1
next reply other threads:[~2011-06-16 9:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 8:23 Wen Congyang [this message]
2011-06-16 10:39 ` [Qemu-devel] [PATCH] fix the return value of rtl8139_can_receive() Kevin Wolf
2011-06-16 12:46 ` Michael S. Tsirkin
2011-06-17 1:33 ` [Qemu-devel] [PATCH] do not send packet to nic if the packet will be dropped by nic Wen Congyang
2011-06-20 9:10 ` Kevin Wolf
2011-06-20 9:40 ` Wen Congyang
2011-06-20 9:52 ` Kevin Wolf
2011-06-20 11:13 ` Michael S. Tsirkin
2011-06-17 1:49 ` [Qemu-devel] [PATCH] fix the return value of rtl8139_can_receive() Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF9BD9C.1060307@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).