From: Richard Henderson <rth@twiddle.net>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>,
Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [Qemu-devel] [RFC][PATCH] Register Linux dyntick timer as per-thread signal
Date: Thu, 16 Jun 2011 07:39:52 -0700 [thread overview]
Message-ID: <4DFA15B8.7090703@twiddle.net> (raw)
In-Reply-To: <4DF9CD7E.5020509@siemens.com>
On 06/16/2011 02:31 AM, Jan Kiszka wrote:
> ev.sigev_value.sival_int = 0;
> - ev.sigev_notify = SIGEV_SIGNAL;
> ev.sigev_signo = SIGALRM;
> +#ifdef SIGEV_THREAD_ID
> + if (qemu_signalfd_available()) {
> + ev.sigev_notify = SIGEV_THREAD_ID;
> + ev._sigev_un._tid = qemu_get_thread_id();
> + } else
> +#endif /* SIGEV_THREAD_ID */
> + {
> + ev.sigev_notify = SIGEV_SIGNAL;
> + }
>
Rather than do the else-inside-ifdef thing, why not
leave the original setting of sigev_notify where it
was, and let the ifdef overwrite it?
r~
next prev parent reply other threads:[~2011-06-16 14:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 9:31 [Qemu-devel] [RFC][PATCH] Register Linux dyntick timer as per-thread signal Jan Kiszka
2011-06-16 10:26 ` Ingo Molnar
2011-06-16 14:39 ` Richard Henderson [this message]
2011-06-16 15:24 ` Alexandre Raymond
2011-06-17 9:25 ` Jan Kiszka
2011-06-17 9:25 ` [Qemu-devel] [PATCH v2] " Jan Kiszka
2011-06-17 18:06 ` Richard Henderson
2011-07-23 16:52 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFA15B8.7090703@twiddle.net \
--to=rth@twiddle.net \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).