From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXa5D-0008NG-Br for qemu-devel@nongnu.org; Fri, 17 Jun 2011 10:31:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXa59-0007oe-PF for qemu-devel@nongnu.org; Fri, 17 Jun 2011 10:31:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXa58-0007n2-SF for qemu-devel@nongnu.org; Fri, 17 Jun 2011 10:31:35 -0400 Message-ID: <4DFB323C.1060306@redhat.com> Date: Fri, 17 Jun 2011 12:53:48 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1308293511-10612-1-git-send-email-adam@os.inf.tu-dresden.de> In-Reply-To: <1308293511-10612-1-git-send-email-adam@os.inf.tu-dresden.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] multiboot: Support commas in module parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Adam Lackorzynski Cc: qemu-devel@nongnu.org Am 17.06.2011 08:51, schrieb Adam Lackorzynski: > Support commas in the parameter list of multiboot modules, by using double > commas (via get_opt_value()). > > Signed-off-by: Adam Lackorzynski The one thing the commit message doesn't mention is that this change requires that commas in -kernel must be escaped by doubling, too. Anyway, I think this behaviour is acceptable. Reviewed-by: Kevin Wolf