From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48874)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QYKCO-0006kQ-9K
	for qemu-devel@nongnu.org; Sun, 19 Jun 2011 11:46:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QYKCN-0005rh-CN
	for qemu-devel@nongnu.org; Sun, 19 Jun 2011 11:46:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5506)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QYKCN-0005rZ-2e
	for qemu-devel@nongnu.org; Sun, 19 Jun 2011 11:46:07 -0400
Message-ID: <4DFE19B9.1030203@redhat.com>
Date: Sun, 19 Jun 2011 18:46:01 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1308495273-23383-1-git-send-email-avi@redhat.com>
	<BANLkTikD7xampygKPvrb1mmMfAPACLGCDw@mail.gmail.com>
In-Reply-To: <BANLkTikD7xampygKPvrb1mmMfAPACLGCDw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Optimize screendump
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org

On 06/19/2011 06:22 PM, Stefan Hajnoczi wrote:
> I wonder if this will break non-Linux platforms.  Perhaps buffer an
> entire row of pixels instead and only fwrite(3) at the end of the
> outer loop.

That's how I wrote this in the first place.  Since the consensus is 
against these functions, I'll submit that version instead.

-- 
error compiling committee.c: too many arguments to function