From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYKU0-0001Rs-Bc for qemu-devel@nongnu.org; Sun, 19 Jun 2011 12:04:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QYKTz-0008E5-2h for qemu-devel@nongnu.org; Sun, 19 Jun 2011 12:04:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1028) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYKTy-0008E1-Kl for qemu-devel@nongnu.org; Sun, 19 Jun 2011 12:04:18 -0400 Message-ID: <4DFE1DFD.2040902@redhat.com> Date: Sun, 19 Jun 2011 19:04:13 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1308495273-23383-1-git-send-email-avi@redhat.com> <4DFE19B9.1030203@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Optimize screendump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Stefan Hajnoczi , qemu-devel@nongnu.org On 06/19/2011 06:53 PM, Andreas F=E4rber wrote: > Am 19.06.2011 um 17:46 schrieb Avi Kivity: > >> On 06/19/2011 06:22 PM, Stefan Hajnoczi wrote: >>> I wonder if this will break non-Linux platforms. Perhaps buffer an >>> entire row of pixels instead and only fwrite(3) at the end of the >>> outer loop. >> >> That's how I wrote this in the first place. Since the consensus is=20 >> against these functions, I'll submit that version instead. > > Maybe add a qemu_fputc_unlocked() and do a configure check for it? Good idea. I'll try that, unless people disagree. --=20 error compiling committee.c: too many arguments to function