From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: "Stefan Hajnoczi" <stefanha@gmail.com>,
"Andreas Färber" <andreas.faerber@web.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Optimize screendump
Date: Mon, 20 Jun 2011 11:04:31 +0300 [thread overview]
Message-ID: <4DFEFF0F.9060908@redhat.com> (raw)
In-Reply-To: <0F14A5B0-7345-41D5-A8D3-B36F820C5294@suse.de>
On 06/19/2011 08:00 PM, Alexander Graf wrote:
> On 19.06.2011, at 18:04, Avi Kivity wrote:
>
> > On 06/19/2011 06:53 PM, Andreas Färber wrote:
> >> Am 19.06.2011 um 17:46 schrieb Avi Kivity:
> >>
> >>> On 06/19/2011 06:22 PM, Stefan Hajnoczi wrote:
> >>>> I wonder if this will break non-Linux platforms. Perhaps buffer an
> >>>> entire row of pixels instead and only fwrite(3) at the end of the
> >>>> outer loop.
> >>>
> >>> That's how I wrote this in the first place. Since the consensus is against these functions, I'll submit that version instead.
> >>
> >> Maybe add a qemu_fputc_unlocked() and do a configure check for it?
> >
> > Good idea. I'll try that, unless people disagree.
>
> Writing by row should be faster and pretty straight forward, no?
I don't see how it's faster, but I guess I'll do that, it's a local
issue and is best addressed locally.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-06-20 8:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-19 14:54 [Qemu-devel] [PATCH] Optimize screendump Avi Kivity
2011-06-19 15:05 ` malc
2011-06-19 15:22 ` Stefan Hajnoczi
2011-06-19 15:46 ` Avi Kivity
2011-06-19 15:53 ` Andreas Färber
2011-06-19 16:04 ` Avi Kivity
2011-06-19 17:00 ` Alexander Graf
2011-06-20 8:04 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFEFF0F.9060908@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=andreas.faerber@web.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).