From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYZTK-0006TI-H7 for qemu-devel@nongnu.org; Mon, 20 Jun 2011 04:04:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QYZTI-0004xn-R3 for qemu-devel@nongnu.org; Mon, 20 Jun 2011 04:04:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYZTI-0004xd-9D for qemu-devel@nongnu.org; Mon, 20 Jun 2011 04:04:36 -0400 Message-ID: <4DFEFF0F.9060908@redhat.com> Date: Mon, 20 Jun 2011 11:04:31 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1308495273-23383-1-git-send-email-avi@redhat.com> <4DFE19B9.1030203@redhat.com> <4DFE1DFD.2040902@redhat.com> <0F14A5B0-7345-41D5-A8D3-B36F820C5294@suse.de> In-Reply-To: <0F14A5B0-7345-41D5-A8D3-B36F820C5294@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Optimize screendump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Stefan Hajnoczi , =?ISO-8859-1?Q?Andreas_F=E4rber?= , qemu-devel@nongnu.org On 06/19/2011 08:00 PM, Alexander Graf wrote: > On 19.06.2011, at 18:04, Avi Kivity wrote: > > > On 06/19/2011 06:53 PM, Andreas F=E4rber wrote: > >> Am 19.06.2011 um 17:46 schrieb Avi Kivity: > >> > >>> On 06/19/2011 06:22 PM, Stefan Hajnoczi wrote: > >>>> I wonder if this will break non-Linux platforms. Perhaps buffer = an > >>>> entire row of pixels instead and only fwrite(3) at the end of the > >>>> outer loop. > >>> > >>> That's how I wrote this in the first place. Since the consensus i= s against these functions, I'll submit that version instead. > >> > >> Maybe add a qemu_fputc_unlocked() and do a configure check for it? > > > > Good idea. I'll try that, unless people disagree. > > Writing by row should be faster and pretty straight forward, no? I don't see how it's faster, but I guess I'll do that, it's a local=20 issue and is best addressed locally. --=20 error compiling committee.c: too many arguments to function