From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] Optimize screendump
Date: Mon, 20 Jun 2011 16:11:13 +0300 [thread overview]
Message-ID: <4DFF46F1.4050109@redhat.com> (raw)
In-Reply-To: <4DFF3E13.60006@siemens.com>
On 06/20/2011 03:33 PM, Jan Kiszka wrote:
> > --- a/hw/vga.c
> > +++ b/hw/vga.c
> > @@ -2349,15 +2349,19 @@ int ppm_save(const char *filename, struct DisplaySurface *ds)
> Unrelated to this patch, but why is this function located in vga.c and
> not in console.c?
It's located in omap_lcdc.c as well. But it needs to be fully
generalized to be moved out (handle all PixelFormats).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-06-20 13:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 8:12 [Qemu-devel] [PATCH v2] Optimize screendump Avi Kivity
2011-06-20 12:33 ` Jan Kiszka
2011-06-20 13:11 ` Avi Kivity [this message]
2011-06-22 21:22 ` Andreas Färber
2011-06-26 17:52 ` Blue Swirl
2011-06-20 15:39 ` Stefan Hajnoczi
2011-06-22 12:58 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFF46F1.4050109@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).