From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42450)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QYeG8-0007FC-DO
	for qemu-devel@nongnu.org; Mon, 20 Jun 2011 09:11:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QYeG6-0006gN-SV
	for qemu-devel@nongnu.org; Mon, 20 Jun 2011 09:11:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60309)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QYeG6-0006g6-6W
	for qemu-devel@nongnu.org; Mon, 20 Jun 2011 09:11:18 -0400
Message-ID: <4DFF46F1.4050109@redhat.com>
Date: Mon, 20 Jun 2011 16:11:13 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1308557567-27600-1-git-send-email-avi@redhat.com>
	<4DFF3E13.60006@siemens.com>
In-Reply-To: <4DFF3E13.60006@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] Optimize screendump
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel@nongnu.org

On 06/20/2011 03:33 PM, Jan Kiszka wrote:
> >  --- a/hw/vga.c
> >  +++ b/hw/vga.c
> >  @@ -2349,15 +2349,19 @@ int ppm_save(const char *filename, struct DisplaySurface *ds)

> Unrelated to this patch, but why is this function located in vga.c and
> not in console.c?

It's located in omap_lcdc.c  as well.  But it needs to be fully 
generalized to be moved out (handle all PixelFormats).

-- 
error compiling committee.c: too many arguments to function