From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53818)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QYfKw-0003EP-1D
	for qemu-devel@nongnu.org; Mon, 20 Jun 2011 10:20:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QYfKu-0001M0-Fw
	for qemu-devel@nongnu.org; Mon, 20 Jun 2011 10:20:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58960)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QYfKt-0001Lo-Vh
	for qemu-devel@nongnu.org; Mon, 20 Jun 2011 10:20:20 -0400
Message-ID: <4DFF57CD.3040108@redhat.com>
Date: Mon, 20 Jun 2011 16:23:09 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <20110617163710.2933.89020.sendpatchset@skannery>
	<20110617163735.2933.67191.sendpatchset@skannery>
In-Reply-To: <20110617163735.2933.67191.sendpatchset@skannery>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [V3 1/3] Enhance "info block" to display hostcache
 setting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Supriya Kannery <supriyak@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>

Am 17.06.2011 18:37, schrieb Supriya Kannery:
> Enhance "info block" to display hostcache setting for each
> block device.
> 
> Example:
> (qemu) info block
> ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2
> encrypted=0
> 
> Enhanced to display "hostcache" setting:
> (qemu) info block
> ide0-hd0: type=hd removable=0 hostcache=true file=../rhel6-32.qcow2 
> ro=0 drv=qcow2 encrypted=0
> 
> Signed-off-by: Supriya Kannery <supriyak@in.ibm.com>
> 
> ---
>  block.c         |   21 +++++++++++++++++----
>  qmp-commands.hx |    2 ++
>  2 files changed, 19 insertions(+), 4 deletions(-)
> 
> Index: qemu/block.c
> ===================================================================
> --- qemu.orig/block.c
> +++ qemu/block.c
> @@ -1694,6 +1694,14 @@ static void bdrv_print_dict(QObject *obj
>          monitor_printf(mon, " locked=%d", qdict_get_bool(bs_dict, "locked"));
>      }
>  
> +	if (qdict_haskey(bs_dict, "open_flags")) {
> +		int open_flags = qdict_get_int(bs_dict, "open_flags");
> +		if (open_flags & BDRV_O_NOCACHE)
> +			monitor_printf(mon, " hostcache=false");
> +		else
> +			monitor_printf(mon, " hostcache=true");

Coding style requires braces.

> +	}
> +
>      if (qdict_haskey(bs_dict, "inserted")) {
>          QDict *qdict = qobject_to_qdict(qdict_get(bs_dict, "inserted"));
>  
> @@ -1730,13 +1738,18 @@ void bdrv_info(Monitor *mon, QObject **r
>          QObject *bs_obj;
>  
>          bs_obj = qobject_from_jsonf("{ 'device': %s, 'type': 'unknown', "
> -                                    "'removable': %i, 'locked': %i }",
> -                                    bs->device_name, bs->removable,
> -                                    bs->locked);
> +									 "'removable': %i, 'locked': %i, "
> +									 "'hostcache': %s }",
> +									 bs->device_name, bs->removable,
> +									 bs->locked,
> +									 (bs->open_flags & BDRV_O_NOCACHE) ?
> +									 "false" : "true");

Don't use tabs.

Kevin