From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYgkI-00049m-Sn for qemu-devel@nongnu.org; Mon, 20 Jun 2011 11:50:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QYgkH-0001Ui-24 for qemu-devel@nongnu.org; Mon, 20 Jun 2011 11:50:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYgkG-0001UR-H9 for qemu-devel@nongnu.org; Mon, 20 Jun 2011 11:50:36 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5KFoZ6M001201 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 Jun 2011 11:50:35 -0400 Message-ID: <4DFF6C48.2020401@redhat.com> Date: Mon, 20 Jun 2011 17:50:32 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1308568312-5463-1-git-send-email-alevy@redhat.com> <1308568312-5463-3-git-send-email-alevy@redhat.com> <4DFF3970.8000804@redhat.com> <20110620125821.GB28412@bow.redhat.com> <4DFF543F.9070205@redhat.com> <20110620151107.GE28412@bow.redhat.com> In-Reply-To: <20110620151107.GE28412@bow.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3&S4 support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, yhalperi@redhat.com On 06/20/11 17:11, Alon Levy wrote: > On Mon, Jun 20, 2011 at 04:07:59PM +0200, Gerd Hoffmann wrote: >>>> What is the difference to one worker->stop() + worker->start() cycle? >>>> >>> >>> ok, stop+start won't disconnect any clients either. But does stop render all waiting commands? >>> I'll have to look, I don't know if it does. >> >> It does. This is what qemu uses to flush all spice server state to >> device memory on migration. >> >> What is the reason for deleting all surfaces? > > Making sure all references are dropped to pci memory in devram. Ah, because the spice server keeps a reference to the create command until the surface is destroyed, right? There is is QXL_IO_DESTROY_ALL_SURFACES + worker->destroy_surfaces() ... The QXL_IO_UPDATE_MEM command does too much special stuff IMHO. I also think we don't need to extend the libspice-server API. We can add a I/O command which renders everything to device memory via stop+start. We can zap all surfaces with the existing command + worker call. We can add a I/O command to ask qxl to push the release queue head to the release ring. Comments? cheers, Gerd