qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: libvir-list@redhat.com, Anthony Liguori <aliguori@us.ibm.com>,
	Corey Bryant <bryntcor@us.ibm.com>,
	Tyler C Hicks <tchicks@us.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] Add support for fd: protocol
Date: Mon, 20 Jun 2011 20:35:05 +0300	[thread overview]
Message-ID: <4DFF84C9.8030909@redhat.com> (raw)
In-Reply-To: <4DFF502A.9020400@codemonkey.ws>

On 06/20/2011 04:50 PM, Anthony Liguori wrote:
> On 06/20/2011 08:40 AM, Avi Kivity wrote:
>> On 06/14/2011 04:31 PM, Corey Bryant wrote:
>>> - Starting Qemu with a backing file
>>>
>>
>> For this we could tell qemu that a file named "xyz" is available via fd
>> n, via an extension of the getfd command.
>>
>> For example
>>
>> (qemu) getfd path="/images/my-image.img"
>> (qemu) getfd path="/images/template.img"
>> (qemu) drive-add path="/images/my-image.img"
>>
>> The open() for my-image.img first looks up the name in the getfd
>> database, and finds it, so it returns the fd from there instead of
>> opening. It then opens the backing file ("template.img") and looks it up
>> again, and finds the second fd from the session.
>
> The way I've been thinking about this is:
>
>  -blockdev id=hd0-back,file=fd:4,format=raw \
>  -blockdev file=fd:3,format=qcow2,backing=hd0-back
>
> While your proposal is clever, it makes me a little nervous about 
> subtle security ramifications.

It would need careful explanation in the management tool author's guide, 
yes.

The main advantage is generality.  It doesn't assume that a file format 
has just one backing file, and doesn't require new syntax wherever a 
file is referred to indirectly.

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2011-06-20 17:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 13:31 [Qemu-devel] [PATCH v2] Add support for fd: protocol Corey Bryant
2011-06-14 16:13 ` [Qemu-devel] [libvirt] " Eric Blake
2011-06-14 19:55   ` Corey Bryant
2011-06-14 20:18     ` Eric Blake
2011-06-14 21:39       ` Corey Bryant
2011-06-14 21:52         ` Eric Blake
2011-06-15 19:12 ` [Qemu-devel] " Blue Swirl
2011-06-16 14:48   ` Corey Bryant
2011-06-18 20:50     ` Blue Swirl
2011-06-20 13:08       ` Corey Bryant
2011-06-20 13:40 ` Avi Kivity
2011-06-20 13:50   ` Anthony Liguori
2011-06-20 17:35     ` Avi Kivity [this message]
2011-06-20 19:11       ` Anthony Liguori
2011-06-21  8:21         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DFF84C9.8030909@redhat.com \
    --to=avi@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=anthony@codemonkey.ws \
    --cc=bryntcor@us.ibm.com \
    --cc=libvir-list@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tchicks@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).