From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZ2ul-0005b3-BT for qemu-devel@nongnu.org; Tue, 21 Jun 2011 11:30:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QZ2uj-0007ES-Qu for qemu-devel@nongnu.org; Tue, 21 Jun 2011 11:30:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZ2uj-0007EH-CD for qemu-devel@nongnu.org; Tue, 21 Jun 2011 11:30:53 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5LFUpdw020600 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Jun 2011 11:30:52 -0400 Received: from dhcp-5-188.str.redhat.com (dhcp-5-175.str.redhat.com [10.32.5.175]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p5LFUo3S031857 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Tue, 21 Jun 2011 11:30:51 -0400 Message-ID: <4E00B9D9.5020602@redhat.com> Date: Tue, 21 Jun 2011 17:33:45 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1306927751-8352-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1306927751-8352-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu-char: Print strerror message on failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Am 01.06.2011 13:29, schrieb Kevin Wolf: > The only way for chardev drivers to communicate an error was to return a NULL > pointer, which resulted in an error message that said _that_ something went > wrong, but not _why_. > > This patch changes the interface to return 0/-errno and updates > qemu_chr_open_opts to use strerror to display a more helpful error message. > > Signed-off-by: Kevin Wolf Ping?