From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZMkp-0008Bx-LK for qemu-devel@nongnu.org; Wed, 22 Jun 2011 08:42:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QZMko-0005Zd-5r for qemu-devel@nongnu.org; Wed, 22 Jun 2011 08:41:59 -0400 Received: from mail-gx0-f174.google.com ([209.85.161.174]:49236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZMkn-0005ZX-UX for qemu-devel@nongnu.org; Wed, 22 Jun 2011 08:41:57 -0400 Received: by gxk21 with SMTP id 21so499243gxk.33 for ; Wed, 22 Jun 2011 05:41:57 -0700 (PDT) Message-ID: <4E01E312.9040307@codemonkey.ws> Date: Wed, 22 Jun 2011 07:41:54 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1308744237-3468-1-git-send-email-armbru@redhat.com> In-Reply-To: <1308744237-3468-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH trivial 0/5] Fix error_report() calls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: stefanha@gmail.com, qemu-devel@nongnu.org On 06/22/2011 07:03 AM, Markus Armbruster wrote: > I limited myself to truly trivial fixes. I hope that's still useful > enough to excuse a little rant. > > "bug: 0 0" is not a useful error message. Neither are "Desc next is > 128", " too short" (too short indeed), "wrong magic" (some "wrong > magic" skills will be handy to figure out what went wrong). I'm > stopping here for brevity's sake, not for want of examples. > > If you can't be bothered to provide an intelligible error message and > *test* it to verify it actually makes sense for the user, maybe you > should stick to assert() or something. Makes your laziness stand out > properly. Acked-by: Anthony Liguori Regards, Anthony Liguori > > Markus Armbruster (5): > sheepdog: qemu_bh_new() can't return null pointer, drop check > Strip trailing '\n' from error_report()'s first argument > qemu-img: Don't prepend qemu-img to error messages twice. > Spell "unkown" correctly in error_report() arguments > blockdev: Put space after comma in error message > > block-migration.c | 2 +- > block/qcow2.c | 2 +- > block/sheepdog.c | 90 ++++++++++++++++++++++------------------------- > blockdev.c | 2 +- > hw/lm32_sys.c | 2 +- > hw/lm32_timer.c | 4 +- > hw/lm32_uart.c | 4 +- > hw/milkymist-ac97.c | 4 +- > hw/milkymist-memcard.c | 4 +- > hw/milkymist-minimac2.c | 6 ++-- > hw/milkymist-pfpu.c | 4 +- > hw/milkymist-softusb.c | 8 ++-- > hw/milkymist-sysctl.c | 4 +- > hw/milkymist-tmu2.c | 8 ++-- > hw/qdev.c | 2 +- > hw/strongarm.c | 4 +- > hw/usb-ccid.c | 2 +- > hw/virtio-serial-bus.c | 10 +++--- > hw/virtio.c | 4 +- > net.c | 2 +- > net/socket.c | 6 ++-- > qemu-error.c | 2 + > qemu-img.c | 12 +++--- > 23 files changed, 92 insertions(+), 96 deletions(-) >