From: Anthony Liguori <anthony@codemonkey.ws>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: patches@linaro.org, qemu-devel@nongnu.org,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix
Date: Wed, 22 Jun 2011 07:58:47 -0500 [thread overview]
Message-ID: <4E01E707.50400@codemonkey.ws> (raw)
In-Reply-To: <1305906601-25324-1-git-send-email-peter.maydell@linaro.org>
On 05/20/2011 10:49 AM, Peter Maydell wrote:
> This patchset reverts commit f68b9d672, which was triggering
> spuriously for NICs created via -device rather than -net nic.
> It then reimplements the improved diagnostics with a different
> approach which only applies to '-net nic'. (It's only -net nic
> devices that can be ignored (ie not instantiated); -device
> nic devices are always instantiated. Checking for -device user
> errors like "this device wasn't plugged into any bus" is
> a separate issue not addressed here.)
>
> Apologies for the regression.
Applied all. Thanks.
Regards,
Anthony Liguori
>
> Peter Maydell (3):
> Revert "net: Improve the warnings for dubious command line option
> combinations"
> net: Don't warn about the default network setup
> net: Warn about "-net nic" options which were ignored
>
> hw/qdev.c | 1 +
> net.c | 42 +++++++++++++++++++-----------------------
> net.h | 3 ++-
> 3 files changed, 22 insertions(+), 24 deletions(-)
>
>
>
prev parent reply other threads:[~2011-06-22 12:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 15:49 [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix Peter Maydell
2011-05-20 15:49 ` [Qemu-devel] [PATCH 1/3] Revert "net: Improve the warnings for dubious command line option combinations" Peter Maydell
2011-05-20 15:50 ` [Qemu-devel] [PATCH 2/3] net: Don't warn about the default network setup Peter Maydell
2011-05-23 8:30 ` Markus Armbruster
2011-05-23 8:55 ` Peter Maydell
2011-05-20 15:50 ` [Qemu-devel] [PATCH 3/3] net: Warn about "-net nic" options which were ignored Peter Maydell
2011-05-23 8:34 ` Markus Armbruster
2011-05-20 15:55 ` [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix Jan Kiszka
2011-05-20 16:04 ` Peter Maydell
2011-05-20 16:07 ` Jan Kiszka
2011-05-20 16:12 ` Peter Maydell
2011-05-20 16:15 ` Jan Kiszka
2011-05-23 8:35 ` Markus Armbruster
2011-06-05 13:12 ` Peter Maydell
2011-06-22 11:39 ` Peter Maydell
2011-06-22 12:58 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E01E707.50400@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).