From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZN19-0003bI-NR for qemu-devel@nongnu.org; Wed, 22 Jun 2011 08:58:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QZN17-00009R-QB for qemu-devel@nongnu.org; Wed, 22 Jun 2011 08:58:51 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:40677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZN17-0008Vm-Fn for qemu-devel@nongnu.org; Wed, 22 Jun 2011 08:58:49 -0400 Received: by mail-yx0-f173.google.com with SMTP id 7so395933yxs.4 for ; Wed, 22 Jun 2011 05:58:49 -0700 (PDT) Message-ID: <4E01E707.50400@codemonkey.ws> Date: Wed, 22 Jun 2011 07:58:47 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1305906601-25324-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1305906601-25324-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: patches@linaro.org, qemu-devel@nongnu.org, Markus Armbruster On 05/20/2011 10:49 AM, Peter Maydell wrote: > This patchset reverts commit f68b9d672, which was triggering > spuriously for NICs created via -device rather than -net nic. > It then reimplements the improved diagnostics with a different > approach which only applies to '-net nic'. (It's only -net nic > devices that can be ignored (ie not instantiated); -device > nic devices are always instantiated. Checking for -device user > errors like "this device wasn't plugged into any bus" is > a separate issue not addressed here.) > > Apologies for the regression. Applied all. Thanks. Regards, Anthony Liguori > > Peter Maydell (3): > Revert "net: Improve the warnings for dubious command line option > combinations" > net: Don't warn about the default network setup > net: Warn about "-net nic" options which were ignored > > hw/qdev.c | 1 + > net.c | 42 +++++++++++++++++++----------------------- > net.h | 3 ++- > 3 files changed, 22 insertions(+), 24 deletions(-) > > >