From: Supriya Kannery <supriyak@in.ibm.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [V3 1/3] Enhance "info block" to display hostcache setting
Date: Wed, 22 Jun 2011 20:29:17 +0530 [thread overview]
Message-ID: <4E020345.5020004@in.ibm.com> (raw)
In-Reply-To: <4DFF57CD.3040108@redhat.com>
On 06/20/2011 07:53 PM, Kevin Wolf wrote:
> Am 17.06.2011 18:37, schrieb Supriya Kannery:
>>
>> + int open_flags = qdict_get_int(bs_dict, "open_flags");
>> + if (open_flags& BDRV_O_NOCACHE)
>> + monitor_printf(mon, " hostcache=false");
>> + else
>> + monitor_printf(mon, " hostcache=true");
>
> Coding style requires braces.
>
Now realising that, by mistake I used checkpatch.pl in linux kernel tree
instead of the one in qemu tree. Will resubmit this patchset after
checking using checkpatch.pl in qemu tree.
next prev parent reply other threads:[~2011-06-22 14:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 16:37 [Qemu-devel] [V3 0/3]block: Dynamically change hostcache setting using new "block_set" command Supriya Kannery
2011-06-17 16:37 ` [Qemu-devel] [V3 1/3] Enhance "info block" to display hostcache setting Supriya Kannery
2011-06-20 14:23 ` Kevin Wolf
2011-06-22 14:59 ` Supriya Kannery [this message]
2011-06-17 16:37 ` [Qemu-devel] [V3 2/3] Error classes for file reopen and device insertion Supriya Kannery
2011-06-20 14:23 ` Kevin Wolf
2011-06-17 16:38 ` [Qemu-devel] [V2 3/3] Command "block_set" for dynamic block params change Supriya Kannery
2011-06-17 17:23 ` [Qemu-devel] [V2 3/3] <Resend> " Supriya Kannery
2011-06-20 14:34 ` [Qemu-devel] [V2 3/3] " Kevin Wolf
2011-06-22 16:09 ` Supriya Kannery
2011-06-27 8:18 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E020345.5020004@in.ibm.com \
--to=supriyak@in.ibm.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).