From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48700)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@in.ibm.com>) id 1QZOiO-0006Hh-KK
	for qemu-devel@nongnu.org; Wed, 22 Jun 2011 10:47:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <supriyak@in.ibm.com>) id 1QZOiK-0004Gp-T9
	for qemu-devel@nongnu.org; Wed, 22 Jun 2011 10:47:36 -0400
Received: from e28smtp05.in.ibm.com ([122.248.162.5]:45719)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@in.ibm.com>) id 1QZOiK-0004Fu-21
	for qemu-devel@nongnu.org; Wed, 22 Jun 2011 10:47:32 -0400
Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58])
	by e28smtp05.in.ibm.com (8.14.4/8.13.1) with ESMTP id p5MElIdT032124
	for <qemu-devel@nongnu.org>; Wed, 22 Jun 2011 20:17:18 +0530
Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63])
	by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p5MElILw4317314
	for <qemu-devel@nongnu.org>; Wed, 22 Jun 2011 20:17:18 +0530
Received: from d28av01.in.ibm.com (loopback [127.0.0.1])
	by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p5MElI4s004786
	for <qemu-devel@nongnu.org>; Wed, 22 Jun 2011 20:17:18 +0530
Message-ID: <4E020345.5020004@in.ibm.com>
Date: Wed, 22 Jun 2011 20:29:17 +0530
From: Supriya Kannery <supriyak@in.ibm.com>
MIME-Version: 1.0
References: <20110617163710.2933.89020.sendpatchset@skannery>
	<20110617163735.2933.67191.sendpatchset@skannery>
	<4DFF57CD.3040108@redhat.com>
In-Reply-To: <4DFF57CD.3040108@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [V3 1/3] Enhance "info block" to display hostcache
 setting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>

On 06/20/2011 07:53 PM, Kevin Wolf wrote:
> Am 17.06.2011 18:37, schrieb Supriya Kannery:
>>
>> +		int open_flags = qdict_get_int(bs_dict, "open_flags");
>> +		if (open_flags&  BDRV_O_NOCACHE)
>> +			monitor_printf(mon, " hostcache=false");
>> +		else
>> +			monitor_printf(mon, " hostcache=true");
>
> Coding style requires braces.
>

Now realising that, by mistake I used checkpatch.pl in linux kernel tree 
instead of the one in qemu tree. Will resubmit this patchset after
checking using checkpatch.pl in qemu tree.