From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51750)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QZcbJ-00020G-61
	for qemu-devel@nongnu.org; Thu, 23 Jun 2011 01:37:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QZcbH-0002FZ-El
	for qemu-devel@nongnu.org; Thu, 23 Jun 2011 01:37:13 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:59267)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QZcbH-0002FS-5m
	for qemu-devel@nongnu.org; Thu, 23 Jun 2011 01:37:11 -0400
Message-ID: <4E02D0FF.4050007@mail.berlios.de>
Date: Thu, 23 Jun 2011 07:37:03 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <cover.1307542247.git.jan.kiszka@siemens.com>	<e7431e8d7e22bc07694bcad0d11508fd48e4173c.1307542247.git.jan.kiszka@siemens.com>
	<4E0255D7.9080202@mail.berlios.de> <4E02608F.7010500@web.de>
In-Reply-To: <4E02608F.7010500@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/12] Switch build system to accompanied
	kernel headers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

Am 22.06.2011 23:37, schrieb Jan Kiszka:
> On 2011-06-22 22:51, Stefan Weil wrote:
>> If not, kvm="yes" should be restricted to platforms with kvm support.
>>
>> Otherwise, QEMU builds will fail very early:
>>
>> ERROR: Host kernel lacks signalfd() support,
>> but KVM depends on it when the IO thread is disabled.
>>
>> Of course, users of those non-kvm platforms can set --disable-kvm,
>> but I don't think that is the correct solution.
>>
>> Even with kvm disabled, builds still fail for non-kvm systems:
>>
>> In file included from /qemu/hw/kvmclock.c:21:
>> /qemu/linux-headers/linux/kvm_para.h:26:26: warning: asm/kvm_para.h: No
>> such file or directory
>
> That indicates symlink emulation under Windows does not support
> directories. Can you confirm this (check what
> <builddir>/linux-headers/asm became)? Then we would have to link all
> files in the arch header dir individually.
>
> Jan

Even when cross compiling for w32 (on a linux host), kvmclock.c
does not compile:

$ LANG=C make CFLAGS=-g
   CC    i386-softmmu/kvmclock.o
In file included from /home/stefan/src/qemu/savannah/qemu/hw/kvmclock.c:20:
/home/stefan/src/qemu/savannah/qemu/linux-headers/linux/kvm.h:10:25: 
warning: linux/types.h: No such file or directory
/home/stefan/src/qemu/savannah/qemu/linux-headers/linux/kvm.h:12:25: 
warning: linux/ioctl.h: No such file or directory
In file included from 
/home/stefan/src/qemu/savannah/qemu/linux-headers/linux/kvm.h:13,
                  from /home/stefan/src/qemu/savannah/qemu/hw/kvmclock.c:20:
../linux-headers/asm/kvm.h:32: error: expected specifier-qualifier-list 
before '__u32'
../linux-headers/asm/kvm.h:41: error: expected specifier-qualifier-list 
before '__u8'
../linux-headers/asm/kvm.h:61: error: expected specifier-qualifier-list 
before '__u64'

Is kvmclock.c really needed for non-kvm platforms? Or does it simply need
a obj-i386-$(CONFIG_KVM) in Makefile.target?

Stefan