From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZeBW-0001GP-JT for qemu-devel@nongnu.org; Thu, 23 Jun 2011 03:18:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QZeBT-0000wx-8d for qemu-devel@nongnu.org; Thu, 23 Jun 2011 03:18:42 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:57071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZeBS-0000wm-LN for qemu-devel@nongnu.org; Thu, 23 Jun 2011 03:18:39 -0400 Message-ID: <4E02E8C8.7070809@web.de> Date: Thu, 23 Jun 2011 09:18:32 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E0255D7.9080202@mail.berlios.de> <4E02608F.7010500@web.de> <4E02D0FF.4050007@mail.berlios.de> In-Reply-To: <4E02D0FF.4050007@mail.berlios.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig825733F4E9C17FF908F4EAF4" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH 03/12] Switch build system to accompanied kernel headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Anthony Liguori , kvm@vger.kernel.org, Marcelo Tosatti , Alexander Graf , qemu-devel@nongnu.org, Avi Kivity This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig825733F4E9C17FF908F4EAF4 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2011-06-23 07:37, Stefan Weil wrote: > Am 22.06.2011 23:37, schrieb Jan Kiszka: >> On 2011-06-22 22:51, Stefan Weil wrote: >>> If not, kvm=3D"yes" should be restricted to platforms with kvm suppor= t. >>> >>> Otherwise, QEMU builds will fail very early: >>> >>> ERROR: Host kernel lacks signalfd() support, >>> but KVM depends on it when the IO thread is disabled. >>> >>> Of course, users of those non-kvm platforms can set --disable-kvm, >>> but I don't think that is the correct solution. >>> >>> Even with kvm disabled, builds still fail for non-kvm systems: >>> >>> In file included from /qemu/hw/kvmclock.c:21: >>> /qemu/linux-headers/linux/kvm_para.h:26:26: warning: asm/kvm_para.h: = No >>> such file or directory >> >> That indicates symlink emulation under Windows does not support >> directories. Can you confirm this (check what >> /linux-headers/asm became)? Then we would have to link all >> files in the arch header dir individually. >> >> Jan >=20 > Even when cross compiling for w32 (on a linux host), kvmclock.c > does not compile: >=20 > $ LANG=3DC make CFLAGS=3D-g > CC i386-softmmu/kvmclock.o > In file included from /home/stefan/src/qemu/savannah/qemu/hw/kvmclock.c= :20: > /home/stefan/src/qemu/savannah/qemu/linux-headers/linux/kvm.h:10:25: > warning: linux/types.h: No such file or directory > /home/stefan/src/qemu/savannah/qemu/linux-headers/linux/kvm.h:12:25: > warning: linux/ioctl.h: No such file or directory > In file included from > /home/stefan/src/qemu/savannah/qemu/linux-headers/linux/kvm.h:13, > from /home/stefan/src/qemu/savannah/qemu/hw/kvmclock.c= :20: > ../linux-headers/asm/kvm.h:32: error: expected specifier-qualifier-list= > before '__u32' > ../linux-headers/asm/kvm.h:41: error: expected specifier-qualifier-list= > before '__u8' > ../linux-headers/asm/kvm.h:61: error: expected specifier-qualifier-list= > before '__u64' >=20 > Is kvmclock.c really needed for non-kvm platforms? Or does it simply ne= ed > a obj-i386-$(CONFIG_KVM) in Makefile.target? It's not needed, specifically as we do not (yet) emulate the pv interfaces of KVM. But changing the makefile won't suffice, we also need to stub out kvmclock_create. Right now I'm fighting to get a mingw build that far at all. The version I have here (gcc 4.6 based) does not include liberity (but apparently links fine without as well). Then there are tons of other errors and warnings. Do you have some tree with recent fixes? I would suggest you to set up a buildbot for the Windows platform. That should help to get notifications about breakages a bit earlier. And that may help to keep their number down (this broken window thing: once the first few got damaged, no one will bother about smashing another one. Jan --------------enig825733F4E9C17FF908F4EAF4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk4C6MwACgkQitSsb3rl5xQlVQCePc05lWgElrTIIWbXA4hCFuZ8 owAAoKTKBOeiofGUHd131a3ZydXwKpvT =8Ajn -----END PGP SIGNATURE----- --------------enig825733F4E9C17FF908F4EAF4--