From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZgky-0002tP-GF for qemu-devel@nongnu.org; Thu, 23 Jun 2011 06:03:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QZgkw-0004gF-M9 for qemu-devel@nongnu.org; Thu, 23 Jun 2011 06:03:28 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:44270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZgkw-0004g8-0g for qemu-devel@nongnu.org; Thu, 23 Jun 2011 06:03:26 -0400 Message-ID: <4E030F6B.7040301@web.de> Date: Thu, 23 Jun 2011 12:03:23 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E030501.3040105@linux.vnet.ibm.com> In-Reply-To: <4E030501.3040105@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig8462EE9B51203436D5EB7104" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH v2 0/3] kvm:showing a splash picture when start List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wayne Xia Cc: Anthony Liguori , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8462EE9B51203436D5EB7104 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: quoted-printable On 2011-06-23 11:18, Wayne Xia wrote: > Hi, > these 3 patch simply enable qemu-kvm to show a logo picture when it= You are posting on qemu-devel (which is correct for this topic), so your patches must target that tree. Patch 1 eg. does not and needs rebasing. > s start up, following is how to configurate it: > invoke it with params: > -boot (splash_time=3D,) (splash_filename=3D,) Simply 'splash' for specifying the file should suffice. > the splash_time is in the unit of ms, and its max value is 65535. > this feature is by default on with 5000ms showing up. Strong NAK for making this default. We have a nice sub-second BIOS time in QEMU, and that must not be destroyed by eye candy. 5 s is also way too long even when you want splash. > Patch 1 contains the source modification for qemu-kvm, Patch 2 and > 3 are binary patches that added a default logo picture file, alternated= > the bios.bin to make the sea-bios showing it. Patch 3 is just used to > provide a convenient way to test the Patch, waiting for newer version > of seabios that provide the support officially. > Any comments would be very nice. - commit logs a missing in the individual patches - the BIOS is updated via submodule reference, and that only to SeaBIOS releases (IOW, you can only provide a test image so far, no patch) - a default logo should not mention KVM but QEMU (splash is not limited to KVM mode) Jan --------------enig8462EE9B51203436D5EB7104 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk4DD2sACgkQitSsb3rl5xRGqwCgu7qr+VA03chcDlKU5iWz7TdE bWMAoJ6BAy3HRUaYyFcjDCVNDdsWjhJC =0mTG -----END PGP SIGNATURE----- --------------enig8462EE9B51203436D5EB7104--