From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZhxb-0001uZ-IY for qemu-devel@nongnu.org; Thu, 23 Jun 2011 07:20:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QZhxZ-0001ZV-PU for qemu-devel@nongnu.org; Thu, 23 Jun 2011 07:20:35 -0400 Received: from e28smtp04.in.ibm.com ([122.248.162.4]:48084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZhxY-0001Yr-T3 for qemu-devel@nongnu.org; Thu, 23 Jun 2011 07:20:33 -0400 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by e28smtp04.in.ibm.com (8.14.4/8.13.1) with ESMTP id p5NBKSQG017482 for ; Thu, 23 Jun 2011 16:50:28 +0530 Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p5NBKEAd3272826 for ; Thu, 23 Jun 2011 16:50:14 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5NBKDCo004574 for ; Thu, 23 Jun 2011 16:50:13 +0530 Message-ID: <4E032166.7060201@linux.vnet.ibm.com> Date: Thu, 23 Jun 2011 19:20:06 +0800 From: Wayne Xia MIME-Version: 1.0 References: <4E030501.3040105@linux.vnet.ibm.com> <4E030F6B.7040301@web.de> In-Reply-To: <4E030F6B.7040301@web.de> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/3] kvm:showing a splash picture when start List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org 2011-6-23 18:03, Jan Kiszka > On 2011-06-23 11:18, Wayne Xia wrote: >> Hi, >> these 3 patch simply enable qemu-kvm to show a logo picture when it > > You are posting on qemu-devel (which is correct for this topic), so your > patches must target that tree. Patch 1 eg. does not and needs rebasing. > thanks for the tip. >> s start up, following is how to configurate it: >> invoke it with params: >> -boot (splash_time=,) (splash_filename=,) > > Simply 'splash' for specifying the file should suffice. > >> the splash_time is in the unit of ms, and its max value is 65535. >> this feature is by default on with 5000ms showing up. > > Strong NAK for making this default. We have a nice sub-second BIOS time > in QEMU, and that must not be destroyed by eye candy. 5 s is also way > too long even when you want splash. > Maybe 5 is a bit too long, this patch is for test so made it a bit longer to be observed by VNC, I think 2.5s would be fit. >> Patch 1 contains the source modification for qemu-kvm, Patch 2 and >> 3 are binary patches that added a default logo picture file, alternated >> the bios.bin to make the sea-bios showing it. Patch 3 is just used to >> provide a convenient way to test the Patch, waiting for newer version >> of seabios that provide the support officially. >> Any comments would be very nice. > > - commit logs a missing in the individual patches I think patch 3/3 may be in the junk mail box. > - the BIOS is updated via submodule reference, and that only to SeaBIOS > releases (IOW, > you can only provide a test image so far, no patch) > - a default logo should not mention KVM but QEMU (splash is not limited > to KVM mode) we can switch it for a more official picture for different release. > Jan > -- Best Regards Wayne Xia mail:xiawenc@linux.vnet.ibm.com tel:86-010-82450803