From: Anthony Liguori <aliguori@us.ibm.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: Wayne Xia <xiawenc@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/3] kvm:showing a splash picture when start
Date: Thu, 23 Jun 2011 09:59:03 -0500 [thread overview]
Message-ID: <4E0354B7.9080902@us.ibm.com> (raw)
In-Reply-To: <20110623120029.GA11202@amd.home.annexia.org>
On 06/23/2011 07:00 AM, Richard W.M. Jones wrote:
> On Thu, Jun 23, 2011 at 05:18:57PM +0800, Wayne Xia wrote:
>> Hi,
>> these 3 patch simply enable qemu-kvm to show a logo picture when it
>> s start up, following is how to configurate it:
>> invoke it with params:
>> -boot (splash_time=<N>,) (splash_filename=<N>,)
>> the splash_time is in the unit of ms, and its max value is 65535.
>> this feature is by default on with 5000ms showing up.
>> Patch 1 contains the source modification for qemu-kvm, Patch 2 and
>> 3 are binary patches that added a default logo picture file, alternated
>> the bios.bin to make the sea-bios showing it. Patch 3 is just used to
>> provide a convenient way to test the Patch, waiting for newer version
>> of seabios that provide the support officially.
>> Any comments would be very nice.
>
> Splash screens are a terrible idea.
No, they're not.
> We should work instead on making the boot even faster.
Having the ability to have an optional splash screen does not slow down
boot for the cases when it's not enabled. It's extremely valuable in
many use-cases to enable branding.
> And having it *default* to 5 seconds! That's like, nearly double the
> time it takes to launch libguestfs completely!!
No one is saying that libguestfs has to enable a splash screen during
it's guest start up.
Regards,
Anthony Liguori
> Please don't accept these patches.
>
> Rich.
>
prev parent reply other threads:[~2011-06-23 14:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 9:18 [Qemu-devel] [PATCH v2 0/3] kvm:showing a splash picture when start Wayne Xia
2011-06-23 10:03 ` Jan Kiszka
2011-06-23 11:14 ` Stefan Hajnoczi
2011-06-23 11:17 ` Jan Kiszka
2011-06-23 12:33 ` Stefan Hajnoczi
2011-06-23 12:36 ` Avi Kivity
2011-06-23 11:56 ` Zhi Yong Wu
2011-06-23 11:57 ` Jan Kiszka
2011-06-23 12:05 ` Zhi Yong Wu
2011-06-23 11:20 ` Wayne Xia
2011-06-23 11:24 ` Jan Kiszka
2011-06-23 12:05 ` Daniel P. Berrange
2011-06-23 12:29 ` Jan Kiszka
2011-06-23 14:46 ` Andreas Färber
2011-06-24 2:28 ` Wayne Xia
2011-06-23 11:46 ` Daniel P. Berrange
2011-06-23 11:41 ` Daniel P. Berrange
2011-06-23 12:00 ` Richard W.M. Jones
2011-06-23 13:38 ` Michael Tokarev
2011-06-23 14:59 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0354B7.9080902@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).