From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZw8c-0006V6-BO for qemu-devel@nongnu.org; Thu, 23 Jun 2011 22:28:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QZw8b-0004yp-Bc for qemu-devel@nongnu.org; Thu, 23 Jun 2011 22:28:54 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:50633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZw8a-0004yd-Qa for qemu-devel@nongnu.org; Thu, 23 Jun 2011 22:28:53 -0400 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [202.81.31.247]) by e23smtp04.au.ibm.com (8.14.4/8.13.1) with ESMTP id p5O2MZ7Q006589 for ; Fri, 24 Jun 2011 12:22:35 +1000 Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p5O2RVF51478692 for ; Fri, 24 Jun 2011 12:27:32 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5O2Shb8027832 for ; Fri, 24 Jun 2011 12:28:43 +1000 Message-ID: <4E03F658.4080107@linux.vnet.ibm.com> Date: Fri, 24 Jun 2011 10:28:40 +0800 From: Wayne Xia MIME-Version: 1.0 References: <4E030501.3040105@linux.vnet.ibm.com> <4E030F6B.7040301@web.de> <4E032166.7060201@linux.vnet.ibm.com> <4E032251.3010103@web.de> <20110623120500.GF14307@redhat.com> <4E033190.7020003@web.de> In-Reply-To: <4E033190.7020003@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/3] kvm:showing a splash picture when start List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org 2011-6-23 20:29, Jan Kiszka : > On 2011-06-23 14:05, Daniel P. Berrange wrote: >> On Thu, Jun 23, 2011 at 01:24:01PM +0200, Jan Kiszka wrote: >>> On 2011-06-23 13:20, Wayne Xia wrote: >>>> 2011-6-23 18:03, Jan Kiszka >>>>> On 2011-06-23 11:18, Wayne Xia wrote: >>>>>> Hi, >>>>>> these 3 patch simply enable qemu-kvm to show a logo picture when it >>>>> >>>>> You are posting on qemu-devel (which is correct for this topic), so your >>>>> patches must target that tree. Patch 1 eg. does not and needs rebasing. >>>>> >>>> thanks for the tip. >>>>>> s start up, following is how to configurate it: >>>>>> invoke it with params: >>>>>> -boot (splash_time=,) (splash_filename=,) >>>>> >>>>> Simply 'splash' for specifying the file should suffice. >>>>> >>>>>> the splash_time is in the unit of ms, and its max value is 65535. >>>>>> this feature is by default on with 5000ms showing up. >>>>> >>>>> Strong NAK for making this default. We have a nice sub-second BIOS time >>>>> in QEMU, and that must not be destroyed by eye candy. 5 s is also way >>>>> too long even when you want splash. >>>>> >>>> Maybe 5 is a bit too long, this patch is for test so made it a bit >>>> longer to be observed by VNC, I think 2.5s would be fit. >>> >>> Maybe it could be something like that if the user specifies a splash >>> file - which indicates that there should be some splash delay as well. >>> Default without any splash parameter must remain 0, ie. disabled. >> >> I don't think you want to change default timeouts based on whether >> a splash screen is present. Consider that if you have enabled PXE boot >> on one of the guest NICs, then there is already a few second delay >> while the BIOS PXEs, during which it QEMU would be showing the splash >> screen. You don't then want to add a further 2.5s or 5s delay ontop >> of that already imposed by the BIOS PXE process. Just let the splash >> screen be displayed for however long the BIOS process takes, without >> any extra artifical delays, even if this is a mere fraction of a >> second in some cases. > > I don't want the splash to show up at all by default, even just for a > fraction of a second. Already loading that image costs time > (specifically as it's squeezed into fwcfg), and that would be unacceptable. > > My point is that, if the user specifies "-boot > splash=my-nice-splace.bmp", there is likely the wish to see the result > more than a few 100 ms. Again, that's the case where the user asked for > a slowdown anyway. > Completely understand that in most cases the Qemu-kvm should boot up as soon as it can. Making this default now is just to provide a convenient way to test it temporarily, I did that to make it easily tested in the GUI--Virtual Machine Manager which would not accept additional parameters to enable the splash screen. Sorry for having not explained it clearly. I agree that if the user specifies it, then this logo would be shown. > Jan > -- Best Regards Wayne Xia mail:xiawenc@linux.vnet.ibm.com tel:86-010-82450803