From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36156)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1QaM1S-00035a-Kp
	for qemu-devel@nongnu.org; Sat, 25 Jun 2011 02:07:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1QaM1R-0004KC-HZ
	for qemu-devel@nongnu.org; Sat, 25 Jun 2011 02:07:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63503)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1QaM1R-0004K8-A6
	for qemu-devel@nongnu.org; Sat, 25 Jun 2011 02:07:13 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5P67Cjj026470
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Sat, 25 Jun 2011 02:07:12 -0400
Received: from localhost.localdomain (vpn1-5-3.ams2.redhat.com [10.36.5.3])
	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id p5P66vfV032348
	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO)
	for <qemu-devel@nongnu.org>; Sat, 25 Jun 2011 02:06:59 -0400
Message-ID: <4E057B53.9080700@redhat.com>
Date: Sat, 25 Jun 2011 08:08:19 +0200
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1308943978-6152-1-git-send-email-hdegoede@redhat.com>	<1308943978-6152-9-git-send-email-hdegoede@redhat.com>
	<201106251015.42820.bradh@frogmouth.net>
In-Reply-To: <201106251015.42820.bradh@frogmouth.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 08/11] usb-ehci: Fix handling of PED and
 PEDC port status bits
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hi,

On 06/25/2011 02:15 AM, Brad Hards wrote:
> 5/11 does this:
> -#define PORTSC_RO_MASK       0x007021c5
> +#define PORTSC_RO_MASK       0x007021c4
>
> before 8/11 does this:
>> -#define PORTSC_RO_MASK       0x007021c4
>> +#define PORTSC_RO_MASK       0x007021c0
>
> You could push those together if there was a v2. I don't think its important
> though.
>

I would rather keep them separate, they happen to
touch the same define, but for completely different
reasons.

Regards,

Hans