From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qb6hs-0003GC-Fi for qemu-devel@nongnu.org; Mon, 27 Jun 2011 03:58:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qb6hp-0006Pc-Cs for qemu-devel@nongnu.org; Mon, 27 Jun 2011 03:58:08 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:42158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qb6ho-0006PH-Id for qemu-devel@nongnu.org; Mon, 27 Jun 2011 03:58:05 -0400 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by e28smtp01.in.ibm.com (8.14.4/8.13.1) with ESMTP id p5R7vuol022074 for ; Mon, 27 Jun 2011 13:27:56 +0530 Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p5R7vts83444942 for ; Mon, 27 Jun 2011 13:27:56 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5R7vtuD012695 for ; Mon, 27 Jun 2011 17:57:55 +1000 Message-ID: <4E083801.7010502@linux.vnet.ibm.com> Date: Mon, 27 Jun 2011 15:57:53 +0800 From: Wayne Xia MIME-Version: 1.0 References: <1309157611-31078-1-git-send-email-xiawenc@linux.vnet.ibm.com> <4E082F7B.3080800@web.de> In-Reply-To: <4E082F7B.3080800@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] showing a splash picture when start List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org > On 2011-06-27 08:53, Wayne Xia wrote: >> Made an option to let qemu pass a picture to bios, let the bios show it as a >> logo. By default it is off, enable it as following > > That's better. :) > >> -boot splash_time=N,splash_filename=P >> N have a max value of 0xffff, unit is ms. P is the a file name or a absolute >> path. >> Currently a trial version of sea-bios could be used to test it. >> >> Signed-off-by: Wayne Xia >> --- > > ... I think making the splash time configurable would be better, maybe we could pass the configuration like following: -boot splash=P, only if splash=P was specified, the splash shows. In this situation, if splash_time was not specified, then show it with a predefined period, such as 2.5 seconds. > >> index c63741c..6f93b10 100644 >> --- a/qemu-config.c >> +++ b/qemu-config.c >> @@ -469,6 +469,32 @@ static QemuOptsList qemu_machine_opts = { >> }, >> }; >> >> +QemuOptsList qemu_bootsplash_opts = { >> + .name = "bootsplash", >> + .head = QTAILQ_HEAD_INITIALIZER(qemu_bootsplash_opts.head), >> + .desc = { >> + /* the three names below are not used now */ >> + { >> + .name = "order", >> + .type = QEMU_OPT_STRING, >> + }, { >> + .name = "once", >> + .type = QEMU_OPT_STRING, >> + }, { >> + .name = "menu", >> + .type = QEMU_OPT_STRING, >> + /* following are really used */ >> + }, { >> + .name = "splash_time", >> + .type = QEMU_OPT_STRING, >> + }, { >> + .name = "splash_filename", >> + .type = QEMU_OPT_STRING, >> + }, >> + { /*End of list */ } >> + }, >> +}; >> + > > This is describing the "boot" option that also controls the splash. > Naming should reflect this. yeah, agree with you. > > Jan > -- Best Regards Wayne Xia mail:xiawenc@linux.vnet.ibm.com tel:86-010-82450803