From: Stefan Weil <weil@mail.berlios.de>
To: Roy Tam <roytam@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] fix MinGW compilation when --enable-vnc-jpeg is specified
Date: Mon, 27 Jun 2011 19:22:02 +0200 [thread overview]
Message-ID: <4E08BC3A.1070708@mail.berlios.de> (raw)
In-Reply-To: <BANLkTimk5v3qDkH1a_RkNoGQ2hX_nxbqpw@mail.gmail.com>
Am 27.06.2011 07:56, schrieb Roy Tam:
> 2011/6/27 Stefan Weil<weil@mail.berlios.de>:
>> Am 27.06.2011 04:37, schrieb TeLeMan:
>>> This patch breaks the compilation with --enable-vnc-png:
>>>
>>> CC ui/vnc-enc-tight.o
>>> In file included from /usr/include/png.h:518,
>>> from ui/vnc-enc-tight.c:34:
>>> /usr/include/pngconf.h:371: error: expected '=', ',', ';', 'asm' or
>>> '__attribute__' before '.' token
>>> /usr/include/pngconf.h:372: error: expected '=', ',', ';', 'asm' or
>>> '__attribute__' before 'include'
>>> make: *** [ui/vnc-enc-tight.o] Error 1
>>>
>>> --
>>> SUN OF A BEACH
>> I get the same compiler error when I run with --enable-vnc-png,
>> and the buildbots got it as well. In my last test, png support
>> was disabled, so I did not notice this problem.
>>
>> The png header files check for prior inclusion of setjmp.h
>> and have a really surprising way of telling that this happened
>> (instead of #error, they use illegal C code - a comment without
>> comment delimiters).
>>
> I wonder which libpng version do you use. Mine is 1.5.2 and it works here.
The critical code is only active for linux (#ifdef __linux__ ... #endif).
I was using linbpng-1.2.42 (ubuntu) and libpng-1.2.44 (debian).
You won't get the problem when compiling with MinGW.
next prev parent reply other threads:[~2011-06-27 17:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-18 5:13 [Qemu-devel] [PATCH] fix MinGW compilation when --enable-vnc-jpeg is specified Roy Tam
2011-06-18 8:35 ` Stefan Weil
2011-06-23 13:52 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2011-06-23 15:05 ` Stefan Weil
2011-06-24 5:30 ` Stefan Hajnoczi
2011-06-26 18:06 ` Blue Swirl
2011-06-26 20:03 ` Stefan Weil
2011-06-26 20:26 ` Blue Swirl
2011-06-27 2:37 ` TeLeMan
2011-06-27 4:15 ` Roy Tam
2011-06-27 5:40 ` Stefan Weil
2011-06-27 5:56 ` Roy Tam
2011-06-27 17:22 ` Stefan Weil [this message]
2011-06-30 15:26 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E08BC3A.1070708@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=qemu-devel@nongnu.org \
--cc=roytam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).