From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34539)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QbFVh-0003J9-Kg
	for qemu-devel@nongnu.org; Mon, 27 Jun 2011 13:22:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QbFVf-0001Ee-Si
	for qemu-devel@nongnu.org; Mon, 27 Jun 2011 13:22:09 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:50006)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QbFVf-0001EE-9C
	for qemu-devel@nongnu.org; Mon, 27 Jun 2011 13:22:07 -0400
Message-ID: <4E08BC3A.1070708@mail.berlios.de>
Date: Mon, 27 Jun 2011 19:22:02 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <BANLkTika6YmzRYAnta8TgQGpLSpoAdpKNQ@mail.gmail.com>
	<4DFC636D.9090800@mail.berlios.de>
	<20110623135202.GA12765@stefanha-thinkpad.localdomain>
	<4E03564A.5060201@mail.berlios.de>
	<BANLkTikP6ietymb3Cg2V5TSPpnjMyWacqA@mail.gmail.com>
	<4E07907F.1060703@mail.berlios.de>
	<BANLkTimZkQ9qBC+Rt0+CCV4TNKTRgttr9A@mail.gmail.com>
	<BANLkTikp8PZoZVbeuHVgDsH2mpLxKs+ytg@mail.gmail.com>
	<4E0817B3.50109@mail.berlios.de>
	<BANLkTimk5v3qDkH1a_RkNoGQ2hX_nxbqpw@mail.gmail.com>
In-Reply-To: <BANLkTimk5v3qDkH1a_RkNoGQ2hX_nxbqpw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] fix MinGW compilation when
 --enable-vnc-jpeg is specified
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Roy Tam <roytam@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

Am 27.06.2011 07:56, schrieb Roy Tam:
> 2011/6/27 Stefan Weil<weil@mail.berlios.de>:
>> Am 27.06.2011 04:37, schrieb TeLeMan:
>>> This patch breaks the compilation with --enable-vnc-png:
>>>
>>> CC ui/vnc-enc-tight.o
>>> In file included from /usr/include/png.h:518,
>>> from ui/vnc-enc-tight.c:34:
>>> /usr/include/pngconf.h:371: error: expected '=', ',', ';', 'asm' or
>>> '__attribute__' before '.' token
>>> /usr/include/pngconf.h:372: error: expected '=', ',', ';', 'asm' or
>>> '__attribute__' before 'include'
>>> make: *** [ui/vnc-enc-tight.o] Error 1
>>>
>>> --
>>> SUN OF A BEACH
>> I get the same compiler error when I run with --enable-vnc-png,
>> and the buildbots got it as well. In my last test, png support
>> was disabled, so I did not notice this problem.
>>
>> The png header files check for prior inclusion of setjmp.h
>> and have a really surprising way of telling that this happened
>> (instead of #error, they use illegal C code - a comment without
>> comment delimiters).
>>
> I wonder which libpng version do you use. Mine is 1.5.2 and it works here.

The critical code is only active for linux (#ifdef __linux__ ... #endif).
I was using linbpng-1.2.42 (ubuntu) and libpng-1.2.44 (debian).

You won't get the problem when compiling with MinGW.