From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
QEMU-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] e1000: Handle IO Port.
Date: Tue, 28 Jun 2011 07:49:19 +0200 [thread overview]
Message-ID: <4E096B5F.7040309@redhat.com> (raw)
In-Reply-To: <BANLkTimHE7GxT-zB9OZR1XaprNQ-kkeciA@mail.gmail.com>
On 06/27/2011 08:07 PM, Peter Maydell wrote:
> > + int ioport_base;
> > + uint32_t ioport_reg[2];
>
> I think ioport_reg[] needs to go in the VMStateDescription as well.
> I don't know enough about the PCI subsystem to know whether that's
> also true of ioport_base or whether the the map function is called
> again on a vmload.
ioport_reg[1] is never written nor read, so this can be changed to a
single uint32_t ioport_addr. Since it will be almost always 0 (either
because it was never written, or because E1000_CTRL == 0), a subsection
is useful to have.
Paolo
next prev parent reply other threads:[~2011-06-28 5:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 16:34 [Qemu-devel] [PATCH] e1000: Handle IO Port Anthony PERARD
2011-06-27 18:07 ` Peter Maydell
2011-06-28 5:49 ` Paolo Bonzini [this message]
2011-06-30 18:45 ` Anthony PERARD
2011-06-30 18:37 ` Anthony PERARD
-- strict thread matches above, loose matches on Subject: below --
2010-10-12 13:58 anthony.perard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E096B5F.7040309@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).