From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43423)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QbRAp-0002Az-Qc
	for qemu-devel@nongnu.org; Tue, 28 Jun 2011 01:49:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QbRAo-0003zT-HI
	for qemu-devel@nongnu.org; Tue, 28 Jun 2011 01:49:23 -0400
Received: from mail-wy0-f173.google.com ([74.125.82.173]:51866)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QbRAo-0003yX-6l
	for qemu-devel@nongnu.org; Tue, 28 Jun 2011 01:49:22 -0400
Received: by wyf28 with SMTP id 28so4092367wyf.4
	for <qemu-devel@nongnu.org>; Mon, 27 Jun 2011 22:49:21 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4E096B5F.7040309@redhat.com>
Date: Tue, 28 Jun 2011 07:49:19 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1309192483-32468-1-git-send-email-anthony.perard@citrix.com>
	<BANLkTimHE7GxT-zB9OZR1XaprNQ-kkeciA@mail.gmail.com>
In-Reply-To: <BANLkTimHE7GxT-zB9OZR1XaprNQ-kkeciA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] e1000: Handle IO Port.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>, QEMU-devel <qemu-devel@nongnu.org>

On 06/27/2011 08:07 PM, Peter Maydell wrote:
> >  +    int ioport_base;
> >  +    uint32_t ioport_reg[2];
>
> I think ioport_reg[] needs to go in the VMStateDescription as well.
> I don't know enough about the PCI subsystem to know whether that's
> also true of ioport_base or whether the the map function is called
> again on a vmload.

ioport_reg[1] is never written nor read, so this can be changed to a 
single uint32_t ioport_addr.  Since it will be almost always 0 (either 
because it was never written, or because E1000_CTRL == 0), a subsection 
is useful to have.

Paolo