From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbX6u-0000Lv-T8 for qemu-devel@nongnu.org; Tue, 28 Jun 2011 08:09:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbX6t-0005W3-Fm for qemu-devel@nongnu.org; Tue, 28 Jun 2011 08:09:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbX6s-0005Vv-Na for qemu-devel@nongnu.org; Tue, 28 Jun 2011 08:09:43 -0400 Message-ID: <4E09C482.6050508@redhat.com> Date: Tue, 28 Jun 2011 15:09:38 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1309180927-19003-1-git-send-email-avi@redhat.com> <1309180927-19003-2-git-send-email-avi@redhat.com> <20110628100343.GA21866@redhat.com> <4E09ACD2.9070907@siemens.com> <4E09C0B2.3030101@redhat.com> <4E09C3F6.8010702@siemens.com> In-Reply-To: <4E09C3F6.8010702@siemens.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 01/20] Hierarchical memory region API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "Michael S. Tsirkin" On 06/28/2011 03:07 PM, Jan Kiszka wrote: > > > > The point is that different buses have different widths. > > target_phys_addr_t matches just one bus in the system. It needs to be > > the maximum size of all buses present to be useful. > > Then we need a type for that. Or we need to demand that > target_phys_addr_t is defined large enough to support all buses that the > particular arch wants to address. Hardcoding 64 bit or anything is not > appropriate for a generic subsystem. Okay, let's make t_p_a_t max(bus size in system). Do we have 32-bit targets that don't support pci (I guess, pc-isa with cpu < ppro?). Do we want to support a 32-bit variant of pci? It certainly existed at some point. -- error compiling committee.c: too many arguments to function