From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbqMW-00012Y-LS for qemu-devel@nongnu.org; Wed, 29 Jun 2011 04:43:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbqMV-00009p-4i for qemu-devel@nongnu.org; Wed, 29 Jun 2011 04:43:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbqDT-00070O-4i for qemu-devel@nongnu.org; Wed, 29 Jun 2011 04:33:47 -0400 Message-ID: <4E0AE365.1070101@redhat.com> Date: Wed, 29 Jun 2011 10:33:41 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1305805037-17752-1-git-send-email-armbru@redhat.com> <1305805037-17752-3-git-send-email-armbru@redhat.com> <20110519131033.GA13222@amit-x200.redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Amit Shah , alevy@redhat.com, Markus Armbruster , qemu-devel@nongnu.org Hi, > Erm, I'm not aware that my qdev bool patch got committed yet, so the > question of how to parse/print bool properties (on/off vs. yes/no) is > still undecided, no comments so far. It would be entirely possible to > let the author decide that on a case-by-case basis by using different > property type enums for the same 'bool' type. Just accept both "on" and "yes" for true and both "off" and "no" for false? For printing we'll have to pick one though. I'd tend to pick on/off as I guess most properties will enable or disable some feature. Or have the two enums ... cheers, Gerd