From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48196)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QbqLE-0000k8-Mi
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 04:41:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QbqLD-0008Bi-A9
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 04:41:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48065)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QbqLC-0008Be-SO
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 04:41:47 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5T8fjeD018102
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 29 Jun 2011 04:41:45 -0400
Message-ID: <4E0AE547.7080602@redhat.com>
Date: Wed, 29 Jun 2011 10:41:43 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1308920577-31569-1-git-send-email-alevy@redhat.com>
	<1308920577-31569-13-git-send-email-alevy@redhat.com>
	<4E083476.2030509@redhat.com>
	<20110627082126.GO2731@bow.redhat.com>
In-Reply-To: <20110627082126.GO2731@bow.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] qxl: add primary_created state,
	change mode lifetimes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: yhalperi <yhalperi@redhat.com>, qemu-devel@nongnu.org

   Hi,

>> Shouldn't the mode change to QXL_MODE_UNDEFINED on DESTROY_SURFACES?
>> (I can see it currently doesn't, but it seems like a mistake)
>
> No, that is the point - this patch makes the lifetime of QXL_MODE_NATIVE be
> the lifetime of the driver in the guest, kinda. we never unload the driver
> in the guest, the only time it stops being operational is when we enter vga
> mode and that's explicitly done when we get any vga port write/read.

I agree with yonit here, moving to UNDEFINED makes sense.  Keeping track 
of guest driver state in qxl is asking for trouble.  It will blow up 
when it comes to S4 support and we'll exit and restart the qemu process.

cheers,
   Gerd