From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbqyI-0007iu-T2 for qemu-devel@nongnu.org; Wed, 29 Jun 2011 05:22:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbqyG-000667-Vg for qemu-devel@nongnu.org; Wed, 29 Jun 2011 05:22:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbqyG-000662-GT for qemu-devel@nongnu.org; Wed, 29 Jun 2011 05:22:08 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5T9M7IK029611 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Jun 2011 05:22:07 -0400 Message-ID: <4E0AEEBD.9000002@redhat.com> Date: Wed, 29 Jun 2011 11:22:05 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1308920577-31569-1-git-send-email-alevy@redhat.com> <1308920577-31569-5-git-send-email-alevy@redhat.com> In-Reply-To: <1308920577-31569-5-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] qxl: allow QXL_IO_LOG also in vga List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: yhalperi@redhat.com, qemu-devel@nongnu.org Hi, > The driver may change us to vga mode and still issue a QXL_IO_LOG, > which we can easily support. > @@ -1001,9 +1001,9 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) > - case QXL_IO_LOG: > case QXL_IO_CREATE_PRIMARY_ASYNC: > case QXL_IO_UPDATE_IRQ: > + case QXL_IO_LOG: > break; That is a NOP, and it also doesn't apply. It isn't the only patch which doesn't apply cleanly, looks like your series isn't based on upstream/master ... cheers, Gerd